Skip to content

JDK-8283497: [windows] print TMP and TEMP in hs_err and VM.info #7901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Mar 22, 2022

Trivial change to add TMP and TEMP - important e.g. to analyze problems with jdk.attach - to the list of environment variables we print into hs-err files and jcmd VM.info.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283497: [windows] print TMP and TEMP in hs_err and VM.info

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7901/head:pull/7901
$ git checkout pull/7901

Update a local copy of the PR:
$ git checkout pull/7901
$ git pull https://git.openjdk.java.net/jdk pull/7901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7901

View PR using the GUI difftool:
$ git pr show -t 7901

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7901.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 22, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2022

Webrevs

Copy link
Member

@YaSuenag YaSuenag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this change is trivial.

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283497: [windows] print TMP and TEMP in hs_err and VM.info

Reviewed-by: ysuenaga, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 6ea996c: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 8cc1235: 8282952: Thread::exit should be immune to Thread.stop
  • 33eb89d: 8283457: [macos] libpng build failures with Xcode13.3
  • f7d21c3: 8283480: Make AbstractStringBuilder sealed
  • d29c7e7: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 557ff4b: 8282625: Formatter caches Locale/DecimalFormatSymbols poorly
  • fabde3b: 8283451: C2: assert(_base == Long) failed: Not a Long
  • c0f984e: 8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only
  • 85628a8: 8282592: C2: assert(false) failed: graph should be schedulable
  • a6fd0b2: 8283087: Create a test or JDK-4715503

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Thanks,
David

@tstuefe
Copy link
Member Author

tstuefe commented Mar 23, 2022

Thanks @YaSuenag and @dholmes-ora !

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit b035fda.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 6ea996c: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 8cc1235: 8282952: Thread::exit should be immune to Thread.stop
  • 33eb89d: 8283457: [macos] libpng build failures with Xcode13.3
  • f7d21c3: 8283480: Make AbstractStringBuilder sealed
  • d29c7e7: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 557ff4b: 8282625: Formatter caches Locale/DecimalFormatSymbols poorly
  • fabde3b: 8283451: C2: assert(_base == Long) failed: Not a Long
  • c0f984e: 8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only
  • 85628a8: 8282592: C2: assert(false) failed: graph should be schedulable
  • a6fd0b2: 8283087: Create a test or JDK-4715503

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@tstuefe Pushed as commit b035fda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants