-
Notifications
You must be signed in to change notification settings - Fork 6k
JDK-8283497: [windows] print TMP and TEMP in hs_err and VM.info #7901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8283497: [windows] print TMP and TEMP in hs_err and VM.info #7901
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this change is trivial.
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
Thanks,
David
Thanks @YaSuenag and @dholmes-ora ! /integrate |
Going to push as commit b035fda.
Your commit was automatically rebased without conflicts. |
Trivial change to add TMP and TEMP - important e.g. to analyze problems with jdk.attach - to the list of environment variables we print into hs-err files and jcmd VM.info.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7901/head:pull/7901
$ git checkout pull/7901
Update a local copy of the PR:
$ git checkout pull/7901
$ git pull https://git.openjdk.java.net/jdk pull/7901/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7901
View PR using the GUI difftool:
$ git pr show -t 7901
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7901.diff