Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283493: Create an automated regression test for JComboBox.setPrototypeDisplayValue() #7905

Closed
wants to merge 2 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Mar 22, 2022

Create a regression test for JDK-4231298
Issue:
When a JComboBox first drops down, the renderer is called for
every element in the list, even those elements that will not
actually be drawn on the screen.

Fix:
Introduced new API to JComboBox: get/setPrototypeDisplayValue(). This API allows the UI to calculate the display size using this prototype value rather than iterated over a large list of items. See RFE 4289100 which also addresses this problem.

Testing:

  1. Tested in Mach5, 10 times per platform(macos,linux and windows) and got all pass.

  2. Tested in JDK 1.3.0 and JDK 1.4.0 and the results are given below.
    Java 1.3.0 -> Test Failed.
    $ jdk1.3/bin/java JComboBoxPrototypeTest
    getListCellRendererComponent index = -1, isSelected = false, cellHasFocus = false
    Value of the Counter is 1
    ....
    getListCellRendererComponent index = -1, isSelected = false, cellHasFocus = false
    Value of the Counter is 101
    Test Failed
    java.lang.RuntimeException: Custom Renderer got called 101 times, expected is maximum 6 times
    at JComboBoxPrototypeTestOld.main(JComboBoxPrototypeTest.java:107)

Java 1.4.0(added a call to setPrototypeDisplayValue()) -> Test Passed.
$ j2sdk1.4.0/bin/java JComboBoxPrototypeTest
getListCellRendererComponent index = -1, isSelected = false, cellHasFocus = false
Value of the Counter is 1
getListCellRendererComponent index = -1, isSelected = false, cellHasFocus = false
Value of the Counter is 2
getListCellRendererComponent index = -1, isSelected = false, cellHasFocus = false
Value of the Counter is 3
Test Passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283493: Create an automated regression test for RFE 4231298

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7905/head:pull/7905
$ git checkout pull/7905

Update a local copy of the PR:
$ git checkout pull/7905
$ git pull https://git.openjdk.java.net/jdk pull/7905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7905

View PR using the GUI difftool:
$ git pr show -t 7905

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7905.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 22, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283493: Create an automated regression test for RFE 4231298

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 372 new commits pushed to the master branch:

  • 6ea996c: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 8cc1235: 8282952: Thread::exit should be immune to Thread.stop
  • 33eb89d: 8283457: [macos] libpng build failures with Xcode13.3
  • f7d21c3: 8283480: Make AbstractStringBuilder sealed
  • d29c7e7: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 557ff4b: 8282625: Formatter caches Locale/DecimalFormatSymbols poorly
  • fabde3b: 8283451: C2: assert(_base == Long) failed: Not a Long
  • c0f984e: 8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only
  • 85628a8: 8282592: C2: assert(false) failed: graph should be schedulable
  • a6fd0b2: 8283087: Create a test or JDK-4715503
  • ... and 362 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@manukumarvs
Your change (at version ce0e62e) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Mar 23, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit 6917c39.
Since your change was applied there have been 392 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@prrace @manukumarvs Pushed as commit 6917c39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8283493 branch May 4, 2022 07:49
@manukumarvs manukumarvs changed the title 8283493: Create an automated regression test for RFE 4231298 8283493: Create an automated regression test for JComboBox.setPrototypeDisplayValue() Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants