8283349 : Robustness improvements to java/util/prefs/AddNodeChangeListener.jar

[bchristi-git]

Please review this change to the java/util/prefs/AddNodeChangeListener.jar test.

Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh Preferences on each test run, MacOS does not seem to honor this, and still stores prefs in Library/.

This test has long suffered intermittent failures. 8255031 added some debugging code; as of that change, the test fails fast as soon as an expected change event is not received. In particular, if the expected event is not received for adding the node, the test exits without removing the node. In this way, on Mac, the node can get "stuck" in the preferences of the machine. Future runs on the machine will already have the node, no node added change event will be generated (because the node was already there), the test will continue to fail without removing the node, etc. This matches observations on some CI machines.

This change ensures that:

• the test node is not present before the test
• the test runs to completion, including removing the test node
• the test node is not left behind after the test

Thanks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar

Reviewers

• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 71ab1f1
• Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to 71ab1f1
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7908/head:pull/7908
$ git checkout pull/7908

Update a local copy of the PR:
$ git checkout pull/7908
$ git pull https://git.openjdk.java.net/jdk pull/7908/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7908

View PR using the GUI difftool:
$ git pr show -t 7908

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7908.diff

[bridgekeeper]

👋 Welcome back bchristi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bchristi-git The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (139b6a94)
• 00: Full (71ab1f17)

[dfuch]

I'm not a regular contributor in this area, so maybe wait to see if a second opinion is forthcoming, but otherwise the proposed changes look reasonable to me.

[openjdk]

@bchristi-git This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar

Reviewed-by: dfuchs, naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 70648a6: 8283368: G1: Remove G1SegmentedArraySegment MEMFLAGS template parameter
• 636225b: 8283607: Rename KlassID to KlassKind
• 6b59760: 8283608: Refactor 2d, beans classes javadoc to use @throws instead of @exception
• 313bc7f: 8267319: Use larger default key sizes and algorithms based on CNSA
• c104802: 8283641: Large value for CompileThresholdScaling causes assert
• dc5a65a: 8283426: Fix 'exeption' typo
• f162445: 8283416: Update java.lang.invoke.MethodHandle to use sealed classes
• 90750de: 8272477: Additional cleanup of test/jdk/java/nio/file/spi/SetDefaultProvider.java
• a7e9883: 8283467: runtime/Thread/StopAtExit.java needs updating
• b36cf35: 8283417: Update java.nio buffers to use sealed classes
• ... and 50 more: https://git.openjdk.java.net/jdk/compare/f8878cb0cc436993ef1222bc13b00b923d91aad1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

Looks good to me.

[bchristi-git]

/integrate

[openjdk]

Going to push as commit 656cba7.
Since your change was applied there have been 61 commits pushed to the master branch:

• f8a1649: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
• 70648a6: 8283368: G1: Remove G1SegmentedArraySegment MEMFLAGS template parameter
• 636225b: 8283607: Rename KlassID to KlassKind
• 6b59760: 8283608: Refactor 2d, beans classes javadoc to use @throws instead of @exception
• 313bc7f: 8267319: Use larger default key sizes and algorithms based on CNSA
• c104802: 8283641: Large value for CompileThresholdScaling causes assert
• dc5a65a: 8283426: Fix 'exeption' typo
• f162445: 8283416: Update java.lang.invoke.MethodHandle to use sealed classes
• 90750de: 8272477: Additional cleanup of test/jdk/java/nio/file/spi/SetDefaultProvider.java
• a7e9883: 8283467: runtime/Thread/StopAtExit.java needs updating
• ... and 51 more: https://git.openjdk.java.net/jdk/compare/f8878cb0cc436993ef1222bc13b00b923d91aad1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bchristi-git Pushed as commit 656cba7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.