Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283467: runtime/Thread/StopAtExit.java needs updating #7910

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Mar 22, 2022

A small fix to convert the runtime/Thread/StopAtExit.java from using the
java.lang.Thread.stop() method to using the JVM/TI StopThread() method.

This fix has been tested with Mach5 Tier[134567] (upper tiers in process)
and StressWrapper_StopAtExit.java testing for 4 hours for each config {release,
fastdebug,slowdebug}. No failures and no memory leaks were observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283467: runtime/Thread/StopAtExit.java needs updating

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7910/head:pull/7910
$ git checkout pull/7910

Update a local copy of the PR:
$ git checkout pull/7910
$ git pull https://git.openjdk.java.net/jdk pull/7910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7910

View PR using the GUI difftool:
$ git pr show -t 7910

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7910.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review March 22, 2022 18:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks,
David

@dholmes-ora
Copy link
Member

You will need to re-test now that JDK-8282952 has integrated.

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283467: runtime/Thread/StopAtExit.java needs updating

Reviewed-by: dholmes, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2022
@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the review.

I'm definitely planning on a retest of this fix. Was there anything
in particular that you are worried about?

@dcubed-ojdk
Copy link
Member Author

Merged with master to pickup the fix for:

JDK-8282952 Thread::exit should be immune to Thread.stop
https://bugs.openjdk.java.net/browse/JDK-8282952

Retesting with Mach5 Tier[13] which are still running.
Also doing a 30 minute stress run of my StressWrapper_StopAtExit.java
in {release,fastdebug,slowdebug} configs.

@dcubed-ojdk
Copy link
Member Author

Could use a second reviewer for this test fix.

@dholmes-ora
Copy link
Member

I'm definitely planning on a retest of this fix. Was there anything in particular that you are worried about?

Nope not worried at all. Just wanted to ensure things were in sync.

@dcubed-ojdk
Copy link
Member Author

Still need a second reviewer for this test fix...

Copy link
Contributor

@pchilano pchilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks,
Patricio

@dcubed-ojdk
Copy link
Member Author

@pchilano - Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

Going to push as commit a7e9883.
Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2022
@openjdk openjdk bot closed this Mar 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@dcubed-ojdk Pushed as commit a7e9883.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8283467 branch March 24, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants