Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283350: (tz) Update Timezone Data to 2022a #7914

Closed
wants to merge 1 commit into from

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Mar 23, 2022

Please review this PR.
The changes only include updates of the zone files that was provided by IANA.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7914/head:pull/7914
$ git checkout pull/7914

Update a local copy of the PR:
$ git checkout pull/7914
$ git pull https://git.openjdk.java.net/jdk pull/7914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7914

View PR using the GUI difftool:
$ git pr show -t 7914

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7914.diff

@satoyoshiki
Copy link
Author

@naotoj @coffeys

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2022

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@satoyoshiki To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283350: (tz) Update Timezone Data to 2022a

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2022
@naotoj
Copy link
Member

naotoj commented Mar 23, 2022

Looks good. BTW, why this PR is still in draft mode?

@satoyoshiki
Copy link
Author

Looks good. BTW, why this PR is still in draft mode?

If my understanding is correct, all interactions here are sent to the corresponding e-mail alias after the PR is set to non-draft. So, to avoid unnecessary interactions in the alias, I usually initiated the PFR from draft. Do you think the PR should be non-draft from beginning?

@satoyoshiki satoyoshiki marked this pull request as ready for review March 24, 2022 01:15
@satoyoshiki
Copy link
Author

/integrate

@openjdk openjdk bot added rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@satoyoshiki
Your change (at version 4f6d469) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 24, 2022

Initiating a PR in draft mode is fine, but reviews should be performed openly. You can control which mail alias reviews are sent.

@coffeys
Copy link
Contributor

coffeys commented Mar 24, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

Going to push as commit b05d4cc.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2022
@openjdk openjdk bot closed this Mar 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@coffeys @satoyoshiki Pushed as commit b05d4cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants