Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel #7915

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Mar 23, 2022

Simple PR, fixing an indentation issue at com.sun.tools.javac.comp.Enter::visitTopLevel, the fix is a one liner,

TIA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7915/head:pull/7915
$ git checkout pull/7915

Update a local copy of the PR:
$ git checkout pull/7915
$ git pull https://git.openjdk.java.net/jdk pull/7915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7915

View PR using the GUI difftool:
$ git pr show -t 7915

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7915.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2022

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@vicente-romero-oracle The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Mar 23, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel

Reviewed-by: darcy, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 23, 2022
@vicente-romero-oracle
Copy link
Contributor Author

vicente-romero-oracle commented Mar 23, 2022

thanks folks, for the review

@vicente-romero-oracle
Copy link
Contributor Author

vicente-romero-oracle commented Mar 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit 6ed0ba2.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 91fab6a: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes
  • d8c5572: 8282204: Use lea instructions for arithmetic operations on x86_64
  • 026b853: 8283298: Make CodeCacheSegmentSize a product flag
  • 58487dd: 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing
  • 86015e1: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
  • 1443f6b: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 82e1a1c: 8283257: x86: Clean up invocation/branch counter updates code
  • b035fda: 8283497: [windows] print TMP and TEMP in hs_err and VM.info

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready rfr labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@vicente-romero-oracle Pushed as commit 6ed0ba2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the JDK-8283543 branch Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
3 participants