Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272477 : Additional cleanup of test/jdk/java/nio/file/spi/SetDefaultProvider.java #7927

Closed
wants to merge 1 commit into from

Conversation

LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Mar 23, 2022

Hi all,

Please review this minor cleanup to test/jdk/java/nio/file/spi/SetDefaultProvider.java

Best
Lance


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272477: Additional cleanup of test/jdk/java/nio/file/spi/SetDefaultProvider.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7927/head:pull/7927
$ git checkout pull/7927

Update a local copy of the PR:
$ git checkout pull/7927
$ git pull https://git.openjdk.java.net/jdk pull/7927/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7927

View PR using the GUI difftool:
$ git pr show -t 7927

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7927.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2022

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@LanceAndersen The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Mar 23, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2022

Webrevs

@@ -190,7 +189,7 @@ private String moduleClasses() {
Path m = Paths.get(dir, "m");
if (Files.exists(m)) return m.toString();
}
assertFalse(true);
Copy link
Member

@bplb bplb Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially like this statement.

bplb
bplb approved these changes Mar 23, 2022
Copy link
Member

@bplb bplb left a comment

+1

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272477: Additional cleanup of test/jdk/java/nio/file/spi/SetDefaultProvider.java

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3e73a0b: 8283237: CallSite should be a sealed class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2022
@LanceAndersen
Copy link
Contributor Author

LanceAndersen commented Mar 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

Going to push as commit 90750de.
Since your change was applied there have been 24 commits pushed to the master branch:

  • a7e9883: 8283467: runtime/Thread/StopAtExit.java needs updating
  • b36cf35: 8283417: Update java.nio buffers to use sealed classes
  • 19f01ab: 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions
  • 929b6a3: 8282917: Remove InetAddressImplFactory from InetAddress
  • 14c20bc: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • 1c4f5fc: 8283575: Check for GNU time fails for version >1.7
  • 2c43ecb: 8283323: libharfbuzz optimization level results in extreme build times
  • 5905b02: 8276799: Implementation of JEP 422: Linux/RISC-V Port
  • b05d4cc: 8283350: (tz) Update Timezone Data to 2022a
  • a35afe8: 8283519: Hsdis with capstone should annotate output
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/a77160065bb6f62314711514f7694fe50f0dc35b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2022
@openjdk openjdk bot closed this Mar 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@LanceAndersen Pushed as commit 90750de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants