-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7156347: javax/swing/JList/6462008/bug6462008.java fails #793
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 18 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a5b7bc5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a test fix for an issue seen to be failing in mach5 testing which JList selection was not correct which seems to stem from the fact that the keypress event was initiated before the frame is made visible.
Fix by adding a robot delay after setVisible and also moved the frame to centre of screen to avoid problems with keypress on window at left edge of monitor.
Mach5 job was run for several iteration on all 3 platforms. Link in JBS.
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/793/head:pull/793
$ git checkout pull/793