Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7156347: javax/swing/JList/6462008/bug6462008.java fails #793

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 22, 2020

Please review a test fix for an issue seen to be failing in mach5 testing which JList selection was not correct which seems to stem from the fact that the keypress event was initiated before the frame is made visible.
Fix by adding a robot delay after setVisible and also moved the frame to centre of screen to avoid problems with keypress on window at left edge of monitor.
Mach5 job was run for several iteration on all 3 platforms. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-7156347: javax/swing/JList/6462008/bug6462008.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/793/head:pull/793
$ git checkout pull/793

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Oct 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2020

Webrevs

mrserb
mrserb approved these changes Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7156347: javax/swing/JList/6462008/bug6462008.java fails

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • b25d894: 8252204: AArch64: Implement SHA3 accelerator/intrinsic
  • 7d3d4da: 8240709: Enable javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java on all L&F
  • 5d26229: 8255174: Vector API unit tests for missed public api code coverage
  • b9186be: 6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")
  • 1191a63: 8199697: FIPS 186-4 RSA Key Generation
  • 60d3fa2: 8255022: Documentation missing for Vector API zero methods
  • 9ade94b: 8206311: Add docs-javase, docs-reference to CI build
  • 3445031: 8255200: ProblemList com/sun/jdi/EATests.java for ZGC
  • 85a8949: 8254913: Increase InlineSmallCode default from 2000 to 2500 for x64
  • 56ea490: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements JavaCritical native functions
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/e559bd2c8bf64888c8890605839d909228c97aaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 22, 2020
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 22, 2020

/integrate

@openjdk openjdk bot closed this Oct 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@prsadhuk Since your change was applied there have been 18 commits pushed to the master branch:

  • b25d894: 8252204: AArch64: Implement SHA3 accelerator/intrinsic
  • 7d3d4da: 8240709: Enable javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java on all L&F
  • 5d26229: 8255174: Vector API unit tests for missed public api code coverage
  • b9186be: 6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")
  • 1191a63: 8199697: FIPS 186-4 RSA Key Generation
  • 60d3fa2: 8255022: Documentation missing for Vector API zero methods
  • 9ade94b: 8206311: Add docs-javase, docs-reference to CI build
  • 3445031: 8255200: ProblemList com/sun/jdi/EATests.java for ZGC
  • 85a8949: 8254913: Increase InlineSmallCode default from 2000 to 2500 for x64
  • 56ea490: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements JavaCritical native functions
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/e559bd2c8bf64888c8890605839d909228c97aaa...master

Your commit was automatically rebased without conflicts.

Pushed as commit a5b7bc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated swing
3 participants