8281717: Cover logout method for several LoginModule #7940

sisahoo · 2022-03-24T10:41:18Z

Added coverage to logout method.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8281717: Cover logout method for several LoginModule

Reviewers

Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7940/head:pull/7940
$ git checkout pull/7940

Update a local copy of the PR:
$ git checkout pull/7940
$ git pull https://git.openjdk.java.net/jdk pull/7940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7940

View PR using the GUI difftool:
$ git pr show -t 7940

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7940.diff

bridgekeeper · 2022-03-24T10:42:20Z

👋 Welcome back ssahoo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-03-24T10:43:53Z

@sisahoo The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-03-24T10:47:16Z

Webrevs

rhalade · 2022-03-24T22:56:03Z

test/jdk/com/sun/security/auth/module/AllPlatforms.java

-                "SolarisLoginModule", "optional");
-        try {
-            login("windows", "NTLoginModule", "required");
-            login("unix", "UnixLoginModule", "required");


thanks for fixing this code. Test earlier skipped UnixLoginModule early on "nix" platform as windows login would fail.

It will run on all platform even the unsuccessful ones appear before.

rhalade · 2022-03-24T22:59:38Z

test/jdk/com/sun/security/auth/module/AllPlatforms.java

-        }
+                UNIX_MODULE, "optional",
+                NT_MODULE, "optional");
+        login(OS.replaceAll("[^a-zA-Z0-9]", ""), getPlatformLoginModule(), "required");


I think test should still be run on all platforms even though login would fail. On other platforms than the test being run on, test shouldn't fail with "UnsatisfiedLinkError" as per JDK-8039951.

Now it will run in all platform other than the running one and the expected failure is LoginException. So any other types of Exception will be treated as failure including UnsatisfiedLinkError.

thanks for addressing it!

rhalade · 2022-03-24T23:02:47Z

test/jdk/com/sun/security/auth/module/AllPlatforms.java

 * @test
- * @bug 8039951
+ * @bug 8039951 8281717


No need to add bug id here as this is not a product change.

Updated exception handling to ignore the case where the running platform doesn't match the test case. In that case required native library loading will fail.

openjdk · 2022-03-29T18:25:40Z

@sisahoo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281717: Cover logout method for several LoginModule

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

9591306: 8283772: Make sun.net.dns.ResolverConfiguration sealed
5359387: 8024624: [TEST_BUG] [macosx] CTRL+RIGHT(LEFT) doesn't move selection on next cell in JTable on Aqua L&F
f074775: 8281284: Write JSlider accessibility test
fe670ff: 8283692: Add PrintIdealPhase that includes block scheduling
ab17f88: 8283626: AArch64: Set relocInfo::offset_unit to 4
c3d903a: 8282936: Write a regression test for JDK-4615365
cc598e0: 8283774: TestZoneOffset::test_immutable should ignore ZoneOffset::rules
0e788e0: 8283781: Avoid allocating unused lastRulesCaches
043b0a7: 8273355: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1
2367228: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
... and 46 more: https://git.openjdk.java.net/jdk/compare/2c43ecb43fa3c94b69478039f1cd70ed4a577768...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

sisahoo · 2022-03-31T06:15:50Z

/integrate

sisahoo · 2022-03-31T06:15:50Z

/integrate

openjdk · 2022-03-31T06:17:11Z

Going to push as commit fbb8ca5.
Since your change was applied there have been 91 commits pushed to the master branch:

e0a8669: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects.
eeca3a3: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables
ec0897a: 8281705: SourceLauncherTest.testSystemProperty isn't being run
1ddab6f: 8283060: RawNativeLibraries should allow multiple clients to load/unload the same library
835c7e8: 8283907: Fix Huawei copyright in various files
b8dd21b: 8283801: Cleanup confusing String.toString calls
ce27d9d: 8283494: Factor out calculation of actual number of XMM registers
e61ccfb: 8283470: Update java.lang.invoke.VarHandle to use sealed classes
e85fa2f: 8283700: Add final or sealed modifier to appropriate java.awt API classes
ec9ab55: 8282374: Java_sun_awt_X11_XlibWrapper_XSynchronize is wrong and unused
... and 81 more: https://git.openjdk.java.net/jdk/compare/2c43ecb43fa3c94b69478039f1cd70ed4a577768...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-03-31T06:17:30Z

@sisahoo Pushed as commit fbb8ca5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2022-03-31T06:17:37Z

@sisahoo The command integrate can only be used in open pull requests.

8281717: Cover logout method for several LoginModule

7c43e30

openjdk bot added the rfr Pull request is ready for review label Mar 24, 2022

openjdk bot added the security security-dev@openjdk.org label Mar 24, 2022

rhalade reviewed Mar 24, 2022

View reviewed changes

sisahoo added 3 commits March 28, 2022 12:23

Update AllPlatforms.java

b72162e

Update AllPlatforms.java

13a999b

Update AllPlatforms.java

b7e3bc0

Updated exception handling to ignore the case where the running platform doesn't match the test case. In that case required native library loading will fail.

rhalade approved these changes Mar 29, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2022

openjdk bot added the integrated Pull request has been integrated label Mar 31, 2022

openjdk bot closed this Mar 31, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2022

8281717: Cover logout method for several LoginModule #7940

8281717: Cover logout method for several LoginModule #7940

sisahoo commented Mar 24, 2022 •

edited by openjdk bot

bridgekeeper bot commented Mar 24, 2022

openjdk bot commented Mar 24, 2022

mlbridge bot commented Mar 24, 2022 •

edited

rhalade Mar 24, 2022

sisahoo Mar 28, 2022

rhalade Mar 24, 2022

sisahoo Mar 28, 2022

rhalade Mar 29, 2022

rhalade Mar 24, 2022

sisahoo Mar 28, 2022

openjdk bot commented Mar 29, 2022

sisahoo commented Mar 31, 2022

sisahoo commented Mar 31, 2022

openjdk bot commented Mar 31, 2022

openjdk bot commented Mar 31, 2022

openjdk bot commented Mar 31, 2022

8281717: Cover logout method for several LoginModule #7940

8281717: Cover logout method for several LoginModule #7940

Conversation

sisahoo commented Mar 24, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 24, 2022

openjdk bot commented Mar 24, 2022

mlbridge bot commented Mar 24, 2022 • edited

Webrevs

rhalade Mar 24, 2022

Choose a reason for hiding this comment

sisahoo Mar 28, 2022

Choose a reason for hiding this comment

rhalade Mar 24, 2022

Choose a reason for hiding this comment

sisahoo Mar 28, 2022

Choose a reason for hiding this comment

rhalade Mar 29, 2022

Choose a reason for hiding this comment

rhalade Mar 24, 2022

Choose a reason for hiding this comment

sisahoo Mar 28, 2022

Choose a reason for hiding this comment

openjdk bot commented Mar 29, 2022

sisahoo commented Mar 31, 2022

sisahoo commented Mar 31, 2022

openjdk bot commented Mar 31, 2022

openjdk bot commented Mar 31, 2022

openjdk bot commented Mar 31, 2022

sisahoo commented Mar 24, 2022 •

edited by openjdk bot

mlbridge bot commented Mar 24, 2022 •

edited