8240903: Add test to check that jmod hashes are reproducible #7948

dongbohe · 2022-03-25T01:50:04Z

This creates a regression test for JDK-8240734. This was once blocked
by a time stamp issue which has been resolved by: JDK-8276766

We found the issue can be produced stably with at least 64 modules.
Note that we need to add the --date jmod option to avoid the timestamp issue.

Testing:
Added test case fails without fix for JDK-8240734, and passes otherwise.
Tested with tier2 on linux x86.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8240903: Add test to check that jmod hashes are reproducible

Reviewers

Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948
$ git checkout pull/7948

Update a local copy of the PR:
$ git checkout pull/7948
$ git pull https://git.openjdk.java.net/jdk pull/7948/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7948

View PR using the GUI difftool:
$ git pr show -t 7948

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7948.diff

bridgekeeper · 2022-03-25T01:50:25Z

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-03-25T01:53:48Z

@dongbohe The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-03-25T01:57:17Z

Webrevs

AlanBateman · 2022-03-25T11:54:52Z

The existing tests for the jmod tool are in test/jdk/tools/jmod. HashesTest.java might provide inspiration to avoid introducing a shell test.

dongbohe · 2022-03-30T01:28:00Z

The existing tests for the jmod tool are in test/jdk/tools/jmod. HashesTest.java might provide inspiration to avoid introducing a shell test.

Hi, Alan

I have rewritten this test in Java in the latest commit.

dongbohe · 2022-04-06T08:38:14Z

@AlanBateman Could you please take another look?

AlanBateman · 2022-04-08T09:26:08Z

I think this looks okay. Can you say how long the test runs for you? It creates 130 JMOD files and I'm just wondering if the default timeout is enough when running with debug builds.

dongbohe · 2022-04-08T10:11:44Z

I think this looks okay. Can you say how long the test runs for you? It creates 130 JMOD files and I'm just wondering if the default timeout is enough when running with debug builds.

The following is the test result on linux x86 with 128 cores, it looks ok.

time make CONF=release run-test TEST=test/jdk/tools/jmod/hashes/HashesOrderTest.java
Finished building target 'run-test' in configuration 'linux-x86_64-server-release'

real	0m24.235s
user	0m52.196s
sys	0m7.170s

time make CONF=slowdebug run-test TEST=test/jdk/tools/jmod/hashes/HashesOrderTest.java
real	2m2.877s
user	5m58.887s
sys	0m10.474s

AlanBateman · 2022-04-10T07:51:52Z

Thanks for the timings. I mostly asked because we've had issues with I/O heavy tests on older macOS tests in our CI. Several tests have had to be dialled down or configured to run with very large timeouts. We'll have to see how this one fares.

openjdk · 2022-04-15T13:22:51Z

@dongbohe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8240903: Add test to check that jmod hashes are reproducible

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 208 new commits pushed to the master branch:

dce7240: 8284921: tier1 test failures after JDK-8284909
9f97f5d: 8283704: Add sealed modifier to java.awt.MultipleGradientPaint
1ebf2f0: 8284909: [JVMCI] remove remnants of AOT support
6199008: 8284914: Problem list test(s) failing due to extra repaints with D3D pipeline.
4cc8ecc: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown
53580b3: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
bdf8a2a: 8283326: Implement SafeFetch statically
bb7c97b: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem
1e22c70: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
510003c: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
... and 198 more: https://git.openjdk.java.net/jdk/compare/bfd9c2b30f17d3341cbe7f48d13d36708e5fafbf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

dongbohe · 2022-04-16T01:10:54Z

Thank you for your review, Alan.
/integrate

openjdk · 2022-04-16T01:11:56Z

@dongbohe
Your change (at version 34b8008) is now ready to be sponsored by a Committer.

RealFYang · 2022-04-16T01:32:26Z

/sponsor

openjdk · 2022-04-16T01:33:55Z

Going to push as commit 9695283.
Since your change was applied there have been 208 commits pushed to the master branch:

dce7240: 8284921: tier1 test failures after JDK-8284909
9f97f5d: 8283704: Add sealed modifier to java.awt.MultipleGradientPaint
1ebf2f0: 8284909: [JVMCI] remove remnants of AOT support
6199008: 8284914: Problem list test(s) failing due to extra repaints with D3D pipeline.
4cc8ecc: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown
53580b3: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
bdf8a2a: 8283326: Implement SafeFetch statically
bb7c97b: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem
1e22c70: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
510003c: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
... and 198 more: https://git.openjdk.java.net/jdk/compare/bfd9c2b30f17d3341cbe7f48d13d36708e5fafbf...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-04-16T01:34:17Z

@RealFYang @dongbohe Pushed as commit 9695283.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8240903: Add a regression test for JDK-8240734

12c3517

openjdk bot added the rfr Pull request is ready for review label Mar 25, 2022

openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 25, 2022

dongbohe added 2 commits March 25, 2022 10:21

Update Copyright

b2a1c84

Get date by 'date +%Y-%m-%dT%H:%M:%S%:z'

aea79a4

Change shell test io java test

6b18593

dongbohe added 2 commits March 30, 2022 09:41

Delete extra blank links

2b81158

Merge branch 'master' into 8240903

34b8008

dongbohe changed the title ~~8240903: Add a regression test for JDK-8240734~~ 8240903: Add test to check that jmod hashes are reproducible Mar 30, 2022

AlanBateman approved these changes Apr 15, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 16, 2022

openjdk bot added the integrated Pull request has been integrated label Apr 16, 2022

openjdk bot closed this Apr 16, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2022

openjdk bot removed the sponsor Pull request is ready to be sponsored label Apr 16, 2022

8240903: Add test to check that jmod hashes are reproducible #7948

8240903: Add test to check that jmod hashes are reproducible #7948

dongbohe commented Mar 25, 2022 •

edited by openjdk bot

bridgekeeper bot commented Mar 25, 2022

openjdk bot commented Mar 25, 2022

mlbridge bot commented Mar 25, 2022 •

edited

AlanBateman commented Mar 25, 2022

dongbohe commented Mar 30, 2022

dongbohe commented Apr 6, 2022

AlanBateman commented Apr 8, 2022

dongbohe commented Apr 8, 2022

AlanBateman commented Apr 10, 2022

openjdk bot commented Apr 15, 2022 •

edited

dongbohe commented Apr 16, 2022

openjdk bot commented Apr 16, 2022

RealFYang commented Apr 16, 2022

openjdk bot commented Apr 16, 2022

openjdk bot commented Apr 16, 2022

8240903: Add test to check that jmod hashes are reproducible #7948

8240903: Add test to check that jmod hashes are reproducible #7948

Conversation

dongbohe commented Mar 25, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 25, 2022

openjdk bot commented Mar 25, 2022

mlbridge bot commented Mar 25, 2022 • edited

Webrevs

AlanBateman commented Mar 25, 2022

dongbohe commented Mar 30, 2022

dongbohe commented Apr 6, 2022

AlanBateman commented Apr 8, 2022

dongbohe commented Apr 8, 2022

AlanBateman commented Apr 10, 2022

openjdk bot commented Apr 15, 2022 • edited

dongbohe commented Apr 16, 2022

openjdk bot commented Apr 16, 2022

RealFYang commented Apr 16, 2022

openjdk bot commented Apr 16, 2022

openjdk bot commented Apr 16, 2022

dongbohe commented Mar 25, 2022 •

edited by openjdk bot

mlbridge bot commented Mar 25, 2022 •

edited

openjdk bot commented Apr 15, 2022 •

edited