JDK-8254189: Improve comments for StackOverFlow and fix in_xxx() functions #795
may I please have reviews for this small cleanup / fix?
While reviewing JDK-8253717 it was found that comments would help with understanding the StackOverFlow class. Especially the fact that the various base are actually pointing outside their respective zone, since the stack grows downward and a zone (and the stack itself) range is [end, base). If you don't look at this code daily it can be surprising.
This also fixes some small off-by-one errors in various "in_stack_xxx_zone()" methods which test whether a given address is inside a zone and gave wrong results for address=base since base points outside its zone. This had the effect that an address could be in multiple zones.
Finally it adds a small gtest which tests the StackOverFlow methods.
Failed test task
The text was updated successfully, but these errors were encountered:
@tstuefe This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 125 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
Personally I'd like to see additional:
in the test, to drive home the point of the inclusion of the ranges, but that's a tiny nick pick.
Thank you, Gerard.
I can do this. Will have to reshape those a bit since there is no "in_yellow_zone" (I considered adding one for tests sake but then did not).
@tstuefe Since your change was applied there have been 125 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 4031cb4.