JDK-8283668: Update IllegalFormatException to use sealed classes #7950
I wonder should the CSR not describe what?s the advantage of this change is and what the compatibility problems are and why they don?t apply here? Especially given the fact that the specific sub exceptions are not sealed I wonder if the risk of breaking existing code is worth it? (But I do see the beauty of such a construct for new code!)
On Fri, 25 Mar 2022 04:17:57 GMT, Joe Darcy <darcy at openjdk.org> wrote:
Marked as reviewed by jpai (Committer).
On 25/03/2022 09:37, Bernd Eckenfels wrote:
IllegalFormatException does not have any accessible constructors so
@jddarcy This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
Right; the general user "interface" in question is "this class cannot be extended outside of the JDK." Altering the way that property is implemented, no accessible constructor or being declared sealed, etc. is considered a compatible change.
Going to push as commit f520b4f.
Your commit was automatically rebased without conflicts.