-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283623: Create an automated regression test for JFileChooser read only property #7969
Conversation
👋 Welcome back mvs! A progress list of the required criteria for merging this PR into |
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@aivanov-jdk Can you please review this. |
test/jdk/javax/swing/JFileChooser/4525475/JFileChooserReadOnlyTest.java
Outdated
Show resolved
Hide resolved
test/jdk/javax/swing/JFileChooser/4525475/JFileChooserReadOnlyTest.java
Outdated
Show resolved
Hide resolved
test/jdk/javax/swing/JFileChooser/4525475/JFileChooserReadOnlyTest.java
Outdated
Show resolved
Hide resolved
test/jdk/javax/swing/JFileChooser/4525475/JFileChooserReadOnlyTest.java
Outdated
Show resolved
Hide resolved
test/jdk/javax/swing/JFileChooser/4525475/JFileChooserReadOnlyTest.java
Outdated
Show resolved
Hide resolved
…laf, result && (readOnly ^ newFolderFound), removed readOnly variable, opptimized checkNewFolderButton() code
test/jdk/javax/swing/JFileChooser/4525475/JFileChooserReadOnlyTest.java
Outdated
Show resolved
Hide resolved
@manukumarvs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 534 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@manukumarvs |
/sponsor |
Going to push as commit 7381868.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk @manukumarvs Pushed as commit 7381868. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Write a regression test for JDK-4525475
Issue:
JFileChooser allows modification to the file-system by way of the "New Folder"
button, and the ability to rename file/folder names. There is no method on
JFileChooser which indicates that this type of modification should not be
allowed within the given JFileChooser.
Testing:
Java 1.4.0 -> Test Failed.
$ j2sdk1.4.0/bin/java Bug4525475
LookAndFeel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Name = Go Up, readOnly = true
Name = New Folder, readOnly = true
Its a Read Only JFileChooser and has a New Folder Button. So Test Failed.
Name = Go Up, readOnly = false
Name = New Folder, readOnly = false
Failed
Java 1.5.0 -> Test Passed.
$ jdk1.5.0/bin/java Bug4525475
LookAndFeel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Name = Go Up, readOnly = true
Name = Go Up, readOnly = false
Name = New Folder, readOnly = false
Passed
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7969/head:pull/7969
$ git checkout pull/7969
Update a local copy of the PR:
$ git checkout pull/7969
$ git pull https://git.openjdk.java.net/jdk pull/7969/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7969
View PR using the GUI difftool:
$ git pr show -t 7969
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7969.diff