Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283623: Create an automated regression test for JFileChooser read only property #7969

Closed
wants to merge 6 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Mar 26, 2022

Write a regression test for JDK-4525475

Issue:
JFileChooser allows modification to the file-system by way of the "New Folder"
button, and the ability to rename file/folder names. There is no method on
JFileChooser which indicates that this type of modification should not be
allowed within the given JFileChooser.

Testing:

  1. Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
  2. Tested in original failed Java version and the fixed version;
    Java 1.4.0 -> Test Failed.
    $ j2sdk1.4.0/bin/java Bug4525475
    LookAndFeel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
    Name = Go Up, readOnly = true
    Name = New Folder, readOnly = true
    Its a Read Only JFileChooser and has a New Folder Button. So Test Failed.
    Name = Go Up, readOnly = false
    Name = New Folder, readOnly = false
    Failed

Java 1.5.0 -> Test Passed.
$ jdk1.5.0/bin/java Bug4525475
LookAndFeel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Name = Go Up, readOnly = true
Name = Go Up, readOnly = false
Name = New Folder, readOnly = false
Passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283623: Create an automated regression test for JDK-4525475

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7969/head:pull/7969
$ git checkout pull/7969

Update a local copy of the PR:
$ git checkout pull/7969
$ git pull https://git.openjdk.java.net/jdk pull/7969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7969

View PR using the GUI difftool:
$ git pr show -t 7969

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7969.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2022
@openjdk
Copy link

openjdk bot commented Mar 26, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 26, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2022

Webrevs

@manukumarvs
Copy link
Member Author

@aivanov-jdk Can you please review this.

…laf, result && (readOnly ^ newFolderFound), removed readOnly variable, opptimized checkNewFolderButton() code
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283623: Create an automated regression test for JDK-4525475

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 534 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 1, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 2, 2022
@openjdk
Copy link

openjdk bot commented Apr 2, 2022

@manukumarvs
Your change (at version 8de5392) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

Going to push as commit 7381868.
Since your change was applied there have been 539 commits pushed to the master branch:

  • f76f5da: 5087440: java.io bulk read(...) end-of-stream return value descriptions ambiguous
  • 36b9baa: 8282508: Updating ASM to 9.2 for JDK 19
  • 4e20a03: 8283044: Use asynchronous handshakes to deliver asynchronous exceptions
  • 9d200d6: 8282756: Make ElementKind checks more specific
  • 1012d59: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters
  • 003ec21: 8279508: Auto-vectorize Math.round API
  • c1e67b6: 8283474: Include detailed heap object info in CDS map file
  • 060a188: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension
  • e5e1aab: 8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state
  • 0b09f70: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • ... and 529 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2022
@openjdk openjdk bot closed this Apr 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@aivanov-jdk @manukumarvs Pushed as commit 7381868.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8283623 branch May 4, 2022 07:49
@manukumarvs manukumarvs changed the title 8283623: Create an automated regression test for JDK-4525475 8283623: Create an automated regression test for JFileChooser read only property Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants