Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows #7974

Closed
wants to merge 7 commits into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Mar 27, 2022

Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.1.0.

This change adds support for building devkits based on VS 2022. Instead of creating a new script file for that I decided to combine it with the logic in createWindowsDevkit2019.sh and rename the resulting file. I decided to dropped support for VS 2017 since that version is pretty old now, let me know if you'd prefer to see it kept around.

Testing: tier1-5 + additional testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7974/head:pull/7974
$ git checkout pull/7974

Update a local copy of the PR:
$ git checkout pull/7974
$ git pull https://git.openjdk.java.net/jdk pull/7974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7974

View PR using the GUI difftool:
$ git pr show -t 7974

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7974.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2022

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2022

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 27, 2022
@vidmik vidmik changed the title Draft: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows Mar 27, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 072f2c4: 8283782: Redundant verification of year in LocalDate::ofEpochDay
  • 2fef5d4: 8281853: serviceability/sa/ClhsdbThreadContext.java failed with NullPointerException: Cannot invoke "sun.jvm.hotspot.gc.shared.GenCollectedHeap.getGen(int)" because "this.heap" is null
  • f9f439a: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2022
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vidmik
Copy link
Contributor Author

vidmik commented Mar 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

Going to push as commit a9a9b90.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 489b27d: 8282776: Bad NullPointerException message when invoking an interface MethodHandle on a null receiver
  • 072f2c4: 8283782: Redundant verification of year in LocalDate::ofEpochDay
  • 2fef5d4: 8281853: serviceability/sa/ClhsdbThreadContext.java failed with NullPointerException: Cannot invoke "sun.jvm.hotspot.gc.shared.GenCollectedHeap.getGen(int)" because "this.heap" is null
  • f9f439a: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2022
@openjdk openjdk bot closed this Mar 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@vidmik Pushed as commit a9a9b90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants