-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows #7974
Conversation
👋 Welcome back mikael! A progress list of the required criteria for merging this PR into |
Webrevs
|
@vidmik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/integrate |
Going to push as commit a9a9b90.
Your commit was automatically rebased without conflicts. |
Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.1.0.
This change adds support for building devkits based on VS 2022. Instead of creating a new script file for that I decided to combine it with the logic in createWindowsDevkit2019.sh and rename the resulting file. I decided to dropped support for VS 2017 since that version is pretty old now, let me know if you'd prefer to see it kept around.
Testing: tier1-5 + additional testing.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7974/head:pull/7974
$ git checkout pull/7974
Update a local copy of the PR:
$ git checkout pull/7974
$ git pull https://git.openjdk.java.net/jdk pull/7974/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7974
View PR using the GUI difftool:
$ git pr show -t 7974
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7974.diff