Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283727: P11KeyGenerator has import statement with two semicolons after JDK-8267319 #7976

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 27, 2022

Remove double semicolon


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283727: P11KeyGenerator has import statement with two semicolons after JDK-8267319

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7976/head:pull/7976
$ git checkout pull/7976

Update a local copy of the PR:
$ git checkout pull/7976
$ git pull https://git.openjdk.java.net/jdk pull/7976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7976

View PR using the GUI difftool:
$ git pr show -t 7976

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7976.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 27, 2022
@openjdk
Copy link

openjdk bot commented Mar 27, 2022

@RealCLanger The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Mar 27, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 27, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283727: P11KeyGenerator has import statement with two semicolons after JDK-8267319

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 27, 2022
@seanjmullan
Copy link
Member

seanjmullan commented Mar 27, 2022

Regarding the bug, the noreg-self label is used for fixes to tests. noreg-trivial seems more appropriate for this issue.

@RealCLanger
Copy link
Contributor Author

RealCLanger commented Mar 27, 2022

Regarding the bug, the noreg-self label is used for fixes to tests. noreg-trivial seems more appropriate for this issue.

You're right, I changed this. Thanks also for the review.

@RealCLanger
Copy link
Contributor Author

RealCLanger commented Mar 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

Going to push as commit cdef087.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7f12537: 8283558: Parallel: Pass PSIsAliveClosure to ReferenceProcessor constructor
  • 66f1da1: 8281222: ciTypeFlow::profiled_count fails "assert(0 <= i && i < _len) failed: illegal index"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 28, 2022
@openjdk openjdk bot closed this Mar 28, 2022
@openjdk openjdk bot removed ready rfr labels Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@RealCLanger Pushed as commit cdef087.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 8283727 branch Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants