-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java #7977
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
@RealCLanger The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this typo.
Looks good to me. (Not a JDK Reviewer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Interestingly, the thing compiles as the package name inside of RISCV64ThreadContext.java is correct and the compiler doesn't bother about the path. Only my Eclipse IDE complained. Thanks for the reviews. /integrate |
Going to push as commit f4eaa16.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit f4eaa16. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fix risv64 -> riscv64
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7977/head:pull/7977
$ git checkout pull/7977
Update a local copy of the PR:
$ git checkout pull/7977
$ git pull https://git.openjdk.java.net/jdk pull/7977/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7977
View PR using the GUI difftool:
$ git pr show -t 7977
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7977.diff