-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes #7984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes #7984
Conversation
👋 Welcome back simonis! A progress list of the required criteria for merging this PR into |
Webrevs
|
Thank you for catching this, Volker. The change looks fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay.
6f121a2
to
810369c
Compare
…heck inflated bytes
810369c
to
814a2f5
Compare
@simonis This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 0c472c8.
Your commit was automatically rebased without conflicts. |
The test
ZipFSOutputStreamTest
deflates content into a zip file system and subsequently inflates the deflated files and checks their content against the original data.The content consists of a data stream of bytes with the value
42
.The check currently compares the temporary inflation buffer with the original source buffer, no matter how many bytes were inflated into the inflation buffer. This can lead to problems with alternative zlib implementations which sometimes write beyond the last inflated byte (see JDK-8282648 for more details).
The fix is trivial. Only compare as many bytes as have been inflated against the original content.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7984/head:pull/7984
$ git checkout pull/7984
Update a local copy of the PR:
$ git checkout pull/7984
$ git pull https://git.openjdk.java.net/jdk pull/7984/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7984
View PR using the GUI difftool:
$ git pr show -t 7984
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7984.diff