Skip to content

8283787: C1: Remove unused ArrayStoreExceptionStub::_info #7992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 28, 2022

SonarCloud complains ArrayStoreExceptionStub::_info field is not initialized. It is not actually used, and the incoming CodeEmitInfo* gets passed to superclass instead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283787: C1: Remove unused ArrayStoreExceptionStub::_info

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7992/head:pull/7992
$ git checkout pull/7992

Update a local copy of the PR:
$ git checkout pull/7992
$ git pull https://git.openjdk.java.net/jdk pull/7992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7992

View PR using the GUI difftool:
$ git pr show -t 7992

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7992.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 28, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283787: C1: Remove unused ArrayStoreExceptionStub::_info

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • a577656: 8282943: Unused weird key in compiler.properties
  • 7f2a3ca: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default
  • 0c472c8: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes
  • d6fa8b0: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • 8567266: 8283683: Make ThreadLocalRandom a final class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2022
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

Going to push as commit aa33525.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 8b65611: 8283789: CompilerPhaseTypeHelper::to_bitmask should operate on uint64_t
  • 9bb916d: 8283800: Simplify String.indexOf/lastIndexOf calls
  • b323f54: 8283846: Remove unused jdk.internal.reflect.SignatureIterator
  • eb5b712: 8283701: Add final or sealed modifier to appropriate java.awt.color ICC_Profile API classes
  • d066856: 8282162: [vector] Optimize integral vector negation API
  • bfd9c2b: 8283015: Create a test for JDK-4715496
  • 8cdabea: 8207025: JvmtiEnv::SetSystemProperty() does not handle OOM
  • 272d653: 8283889: Fix Typo in open/src/java.sql/share/classes/java/sql/package-info.java
  • a9a9b90: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 489b27d: 8282776: Bad NullPointerException message when invoking an interface MethodHandle on a null receiver
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/f4eaa16c0fe0659376325cec1c912a13ef0f1be8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@shipilev Pushed as commit aa33525.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8283787-unused-ases-info branch April 6, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants