Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283624: Create an automated regression test for JFileChooser.setLocation() #7996

Closed
wants to merge 4 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Mar 28, 2022

Write a regression test for JDK-4390885 Enhancement Request.

Issue:
Please add the ability to set the location of a JFileChooser. This might be a
bug, but JFileChooser.setLocation() has no effect when
JFileChooser.showXXXXDialog() is called. This is becoming very important as the
popularity of multiple monitors is increasing. These dialogs show up on the
wrong monitor which is really annoying. Also due to bug #4189244 I am unable to
avoid painting problems by positioning the dialog away from the menu item that
initiated it.

Fix:
Now it's possible to set the location of Dialog in JFileChooser.

Testing:

  1. Tested in Mach5 10 times per platform(macos,linux,windows) and got all Pass.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283624: Create an automated regression test for RFE-4390885

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7996/head:pull/7996
$ git checkout pull/7996

Update a local copy of the PR:
$ git checkout pull/7996
$ git pull https://git.openjdk.java.net/jdk pull/7996/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7996

View PR using the GUI difftool:
$ git pr show -t 7996

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7996.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 28, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

@manukumarvs
Copy link
Member Author

Any volunteers ?

@manukumarvs
Copy link
Member Author

@aivanov-jdk Can you please review this.

@manukumarvs
Copy link
Member Author

@aivanov-jdk Can you review this.

@manukumarvs
Copy link
Member Author

Any volunteers?

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283624: Create an automated regression test for RFE-4390885

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 852 new commits pushed to the master branch:

  • e2e943a: 8285688: Add links to JEPs and JSRs to SourceVersion
  • 80cf59f: 8285610: TreeInfo.pathFor and its uses appear to be dead code
  • 21b62fe: 8195589: T6587786.java failed after JDK-8189997
  • 8190217: 8285496: DocLint does not check for missing @param tags for type parameters on classes and interfaces
  • 64d98ba: 8285094: Test java/awt/Frame/InvisibleOwner/InvisibleOwner.java failing on Linux
  • 573eace: 8285504: Minor cleanup could be done in javax.net
  • bba456a: 8285676: Add missing @param tags for type parameters on classes and interfaces
  • b9d1e85: 8285785: CheckCleanerBound test fails with PasswordCallback object is not released
  • b718578: 8285011: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java fails after JDK-8280761
  • 2d8d140: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
  • ... and 842 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs
Your change (at version 54c4a6a) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 99388ef.
Since your change was applied there have been 853 commits pushed to the master branch:

  • 94b533a: 8285699: riscv: Provide information when hitting a HaltNode
  • e2e943a: 8285688: Add links to JEPs and JSRs to SourceVersion
  • 80cf59f: 8285610: TreeInfo.pathFor and its uses appear to be dead code
  • 21b62fe: 8195589: T6587786.java failed after JDK-8189997
  • 8190217: 8285496: DocLint does not check for missing @param tags for type parameters on classes and interfaces
  • 64d98ba: 8285094: Test java/awt/Frame/InvisibleOwner/InvisibleOwner.java failing on Linux
  • 573eace: 8285504: Minor cleanup could be done in javax.net
  • bba456a: 8285676: Add missing @param tags for type parameters on classes and interfaces
  • b9d1e85: 8285785: CheckCleanerBound test fails with PasswordCallback object is not released
  • b718578: 8285011: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java fails after JDK-8280761
  • ... and 843 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@akolarkunnu @manukumarvs Pushed as commit 99388ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs changed the title 8283624: Create an automated regression test for RFE-4390885 8283624: Create an automated regression test for JFileChooser.setLocation() Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants