8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

[shipilev]

Bisection shows it started to happen after JDK-8253660. I believe toString() there is not very resilient in the face of null causes.

Example output:

$ make run-test TEST=compiler/aot

STDERR:
java.lang.NullPointerException: Cannot invoke "java.lang.Throwable.getCause()" because "<local1>" is null
at jdk.test.lib.artifacts.ArtifactResolverException.getRootCause(ArtifactResolverException.java:22)
at jdk.test.lib.artifacts.ArtifactResolverException.toString(ArtifactResolverException.java:17)
...
at compiler.aot.AotCompiler.resolveLinker(AotCompiler.java:270)
at compiler.aot.AotCompiler.launchCompiler(AotCompiler.java:112)
at compiler.aot.AotCompiler.main(AotCompiler.java:78)
...

...and since it is a part of this block:

        } catch (ArtifactResolverException e) {
            System.err.println("artifact resolution error: " + e); // <--- calling to broken toString() here
            e.printStackTrace(System.err);
            // let jaotc try to find linker
            return null;
        }

...we never actually get to // let jaotc try to find linker part, and that is why I suspect it causes Windows x86_64 tier1/compiler failures in GitHub workflows. See below, Windows tier1/compiler tests are now passing. (There are some infra failures in other places on Windows, though).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x32	Linux x64	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)		✔️ (9/9 passed)	❌ (1/9 failed)	✔️ (9/9 passed)

Failed test task

• Windows x64 (jdk/tier1 part 1)

Issue

• JDK-8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/800/head:pull/800
$ git checkout pull/800

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• 2d
• awt
• beans
• build
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah
• sound
• swing

[shipilev]

/label build

[openjdk]

@shipilev
The build label was successfully added.

[mlbridge]

Webrevs

• 00: Full (78505b3)

[erikj79]

Looks good, thanks for fixing it!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

Reviewed-by: erikj, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
• 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag
• a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
• f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
• 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended
• cc50c8d: 8255196: Remove unused G1FullGCCompactionPoint::merge()
• ae72b52: 8255047: Add HotSpot UseDebuggerErgo flags
• 211bb62: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonitorStateException: current thread is not owner
• 299e115: 8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5
• a5b7bc5: 7156347: javax/swing/JList/6462008/bug6462008.java fails
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/8d9e6d01fb4cfdc1d5e1bcc0f30157158b974bd3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks @erikj79! I want this fixed sooner, is it OK to push now? Or should we ask someone else to review too?

[RealCLanger]

Looks good. Thanks for fixing it. I saw it in our CI as well.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 26 commits pushed to the master branch:

• a824781: 8255210: [Vector API] jdk/incubator/vector/Int256VectorTests.java crashes on AVX512 machines
• 2ca7a08: 8255268: 32-bit failures in runtime/Metaspace/elastic
• d8d9197: 8242559: Clean the "libawt_xawt" library from code for headless mode
• ff5f226: 8255086: Update the root locale display names
• 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
• 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag
• a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
• f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
• 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended
• cc50c8d: 8255196: Remove unused G1FullGCCompactionPoint::merge()
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/8d9e6d01fb4cfdc1d5e1bcc0f30157158b974bd3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 64dc4b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.