Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283806: [BACKOUT] JDK 19 L10n resource files update - msgdrop 10 #8005

Closed
wants to merge 1 commit into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Mar 28, 2022

This reverts commit c0aecd1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283806: [BACKOUT] JDK 19 L10n resource files update - msgdrop 10

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8005/head:pull/8005
$ git checkout pull/8005

Update a local copy of the PR:
$ git checkout pull/8005
$ git pull https://git.openjdk.java.net/jdk pull/8005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8005

View PR using the GUI difftool:
$ git pr show -t 8005

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8005.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2022

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@alisenchung The following labels will be automatically applied to this pull request:

  • client
  • compiler
  • core-libs
  • i18n
  • javadoc
  • jmx
  • kulla
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc security serviceability jmx client core-libs compiler net kulla i18n labels Mar 28, 2022
Copy link
Member

@kevinrushforth kevinrushforth left a comment

I confirm that this is an exact backout of JDK-8280400.

@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

naotoj
naotoj approved these changes Mar 28, 2022
Copy link
Member

@naotoj naotoj left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283806: [BACKOUT] JDK 19 L10n resource files update - msgdrop 10

Reviewed-by: kcr, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9b49900: 8283603: Remove redundant qualifier in Windows specific Attach Operation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 28, 2022
@alisenchung
Copy link
Contributor Author

alisenchung commented Mar 28, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@alisenchung
Your change (at version 29aadff) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 28, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

Going to push as commit 634800a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9b49900: 8283603: Remove redundant qualifier in Windows specific Attach Operation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 28, 2022
@openjdk openjdk bot closed this Mar 28, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@naotoj @alisenchung Pushed as commit 634800a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client compiler core-libs i18n integrated javadoc jmx kulla net security serviceability
3 participants