8283597: [REDO] Invalid generic signature for redefined classes

[alexmenkov]

After pushing fix for JDK-8282241 (#7676) random tests from serviceability/jvmti/RedefineClasses start to fail with
java.lang.NoClassDefFoundError: jdk/test/lib/helpers/ClassFileInstaller$Manifest
This is caused by JTReg classpath directories sharing between tests.

Research shown that the issue was caused by using
run compile -g RedefineGenericSignatureTest.java
in the test to include additional debug info.
Actually "-g" it's not needed as the test only needs source file data and it's included by default.

The fix is the same as previous one, the only difference is in the test:

• removed "run compile -g RedefineGenericSignatureTest.java" action;
• removed "-g" option from InMemoryJavaCompiler.compile() call.

Tested with debug and release builds, 1500 runs without failures.

@coleenp , @sspitsyn : could you please re-review the fix

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283597: [REDO] Invalid generic signature for redefined classes

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8007/head:pull/8007
$ git checkout pull/8007

Update a local copy of the PR:
$ git checkout pull/8007
$ git pull https://git.openjdk.java.net/jdk pull/8007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8007

View PR using the GUI difftool:
$ git pr show -t 8007

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8007.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d9e7aa7a)

[sspitsyn]

Looks good to me.
It is nice you've found the root cause of this regression!
Thanks,
Serguei

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283597: [REDO] Invalid generic signature for redefined classes

Reviewed-by: sspitsyn, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 95 new commits pushed to the master branch:

• 38df570: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10
• ad83ec7: 8283422: Create a new test for JDK-8254790
• 6ebf845: 8283566: G1: Improve G1BarrierSet::enqueue performance
• d276da5: 8281469: aarch64: Improve interpreter stack banging
• a41550b: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException
• 207b099: 8283890: Changes in CFG file format break C1Visualizer
• 49fcc7a: 8283013: Simplify Arguments::parse_argument()
• 73cb922: 8284026: Use unmodifiable collections where practical
• 77a205a: 8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile
• 64025b0: 8283901: Introduce "make doctor" to diagnose build environment problems
• ... and 85 more: https://git.openjdk.java.net/jdk/compare/f4fd53d0aee67319bf2c7bcaa671c2e97e66383f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Yes, this looks good, not that I understand the inner workings of jtreg. All but two tests in that directory don't @compile the test case.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 0cd46f6.
Since your change was applied there have been 121 commits pushed to the master branch:

• e297074: 8284181: ArgumentsTest.set_numeric_flag_double_vm fails on some locales
• 732f7ae: 8284071: Collapse identical catch branches in jdk.console
• 61d06c2: 8276050: XMLInputFactoryImpl.getProperty() returns null
• 7381868: 8283623: Create an automated regression test for JDK-4525475
• f76f5da: 5087440: java.io bulk read(...) end-of-stream return value descriptions ambiguous
• 36b9baa: 8282508: Updating ASM to 9.2 for JDK 19
• 4e20a03: 8283044: Use asynchronous handshakes to deliver asynchronous exceptions
• 9d200d6: 8282756: Make ElementKind checks more specific
• 1012d59: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters
• 003ec21: 8279508: Auto-vectorize Math.round API
• ... and 111 more: https://git.openjdk.java.net/jdk/compare/f4fd53d0aee67319bf2c7bcaa671c2e97e66383f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 0cd46f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.