Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283701: Add final or sealed modifier to appropriate java.awt.color ICC_Profile API classes #8021

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Mar 29, 2022

This PR is similar to https://git.openjdk.java.net/jdk/pull/7998 but addresses some Java 2D API color related classes.

ICC_Profile can be made sealed, and the two extant sub-classes can be made final.

All regression and JCK tests have passed

CSR is here https://bugs.openjdk.java.net/browse/JDK-8283891


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8283701: Add final or sealed modifier to appropriate java.awt.color ICC_Profile API classes
  • JDK-8283891: Add final or sealed modifier to appropriate java.awt.color ICC_Profile API classes (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8021/head:pull/8021
$ git checkout pull/8021

Update a local copy of the PR:
$ git checkout pull/8021
$ git pull https://git.openjdk.java.net/jdk pull/8021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8021

View PR using the GUI difftool:
$ git pr show -t 8021

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8021.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mrserb
Copy link
Member

mrserb commented Mar 29, 2022

All regression and JCK tests have passed

I think the sigtests should fail after this patch?

@prrace
Copy link
Contributor Author

prrace commented Mar 29, 2022

All regression and JCK tests have passed

I think the sigtests should fail after this patch?

Well, true, except the signature tests are not included in the test harness runs.
They are the only ones excluded. The CSR will cover us there.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283701: Add final or sealed modifier to appropriate java.awt.color ICC_Profile API classes

Reviewed-by: bpb, aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • d066856: 8282162: [vector] Optimize integral vector negation API
  • bfd9c2b: 8283015: Create a test for JDK-4715496
  • 8cdabea: 8207025: JvmtiEnv::SetSystemProperty() does not handle OOM
  • 272d653: 8283889: Fix Typo in open/src/java.sql/share/classes/java/sql/package-info.java
  • a9a9b90: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 489b27d: 8282776: Bad NullPointerException message when invoking an interface MethodHandle on a null receiver
  • 072f2c4: 8283782: Redundant verification of year in LocalDate::ofEpochDay
  • 2fef5d4: 8281853: serviceability/sa/ClhsdbThreadContext.java failed with NullPointerException: Cannot invoke "sun.jvm.hotspot.gc.shared.GenCollectedHeap.getGen(int)" because "this.heap" is null
  • f9f439a: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
  • 9591306: 8283772: Make sun.net.dns.ResolverConfiguration sealed
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/c2c0cb2a4372d78658326461562363de9a1a194f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2022
@prrace
Copy link
Contributor Author

prrace commented Mar 30, 2022

/integrate

1 similar comment
@prrace
Copy link
Contributor Author

prrace commented Mar 30, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

Going to push as commit eb5b712.
Since your change was applied there have been 36 commits pushed to the master branch:

  • d066856: 8282162: [vector] Optimize integral vector negation API
  • bfd9c2b: 8283015: Create a test for JDK-4715496
  • 8cdabea: 8207025: JvmtiEnv::SetSystemProperty() does not handle OOM
  • 272d653: 8283889: Fix Typo in open/src/java.sql/share/classes/java/sql/package-info.java
  • a9a9b90: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 489b27d: 8282776: Bad NullPointerException message when invoking an interface MethodHandle on a null receiver
  • 072f2c4: 8283782: Redundant verification of year in LocalDate::ofEpochDay
  • 2fef5d4: 8281853: serviceability/sa/ClhsdbThreadContext.java failed with NullPointerException: Cannot invoke "sun.jvm.hotspot.gc.shared.GenCollectedHeap.getGen(int)" because "this.heap" is null
  • f9f439a: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
  • 9591306: 8283772: Make sun.net.dns.ResolverConfiguration sealed
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/c2c0cb2a4372d78658326461562363de9a1a194f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@prrace Pushed as commit eb5b712.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@prrace The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants