Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283997: Unused argument in GraphKit::builtin_throw #8038

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 30, 2022

Trivial fix that removes an unused argument and adjust a comment accordingly.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283997: Unused argument in GraphKit::builtin_throw

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8038/head:pull/8038
$ git checkout pull/8038

Update a local copy of the PR:
$ git checkout pull/8038
$ git pull https://git.openjdk.java.net/jdk pull/8038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8038

View PR using the GUI difftool:
$ git pr show -t 8038

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8038.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

Copy link
Contributor

@rwestrel rwestrel left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283997: Unused argument in GraphKit::builtin_throw

Reviewed-by: roland, redestad, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 30, 2022
cl4es
cl4es approved these changes Mar 30, 2022
@TobiHartmann
Copy link
Member Author

TobiHartmann commented Mar 30, 2022

Roland, Claes, thanks for the quick reviews!

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Mar 30, 2022

Just noticed that I forgot to push the changes in the calling methods.

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Mar 30, 2022

Fixed :)

cl4es
cl4es approved these changes Mar 30, 2022
@TobiHartmann
Copy link
Member Author

TobiHartmann commented Mar 31, 2022

Thanks for the (re-)reviews!

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Mar 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

Going to push as commit a11cc97.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 067b258: 8224977: [macos] On AquaLookAndFeel, Iconified JInternalFrame does not restore when Control + F5 is used.
  • 0a9a7b6: 8283642: JavaDoc of JFileChooser() need to be updated for default directory in Windows
  • 1a5f5da: 8283996: Reduce cost of year and month calculations
  • 45d4d7d: 8283337: Posix signal handler modification warning triggering incorrectly
  • 3d4be14: 8181571: printing to CUPS fails on mac sandbox app
  • ef51dfd: 8283791: Parallel: Remove unnecessary condition in PSKeepAliveClosure
  • 3e643f4: 8283799: Collapse identical catch branches in jdk.hotspot.agent
  • 1ca0ede: 8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM
  • c9a469a: 8283784: java_lang_String::as_platform_dependent_str stores to oop in native state
  • fbb8ca5: 8281717: Cover logout method for several LoginModule
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/720e751f35150251cab05bc9fca3add39daf70af...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 31, 2022
@openjdk openjdk bot closed this Mar 31, 2022
@openjdk openjdk bot removed ready rfr labels Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@TobiHartmann Pushed as commit a11cc97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
4 participants