Skip to content

8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Mar 30, 2022

Fixes test failures caused by depending on the default locale. Specifying explicit Locale.US will do.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8045/head:pull/8045
$ git checkout pull/8045

Update a local copy of the PR:
$ git checkout pull/8045
$ git pull https://git.openjdk.java.net/jdk pull/8045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8045

View PR using the GUI difftool:
$ git pr show -t 8045

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8045.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException

Reviewed-by: iris, rriggs, scolebourne

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

  • ce27d9d: 8283494: Factor out calculation of actual number of XMM registers
  • e61ccfb: 8283470: Update java.lang.invoke.VarHandle to use sealed classes
  • e85fa2f: 8283700: Add final or sealed modifier to appropriate java.awt API classes
  • ec9ab55: 8282374: Java_sun_awt_X11_XlibWrapper_XSynchronize is wrong and unused
  • a625bfd: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • 97c7298: 8282046: Create a regression test for JDK-8000326
  • ae57258: 8283715: Update ObjectStreamClass to be final
  • d9d19e9: 8284015: ProblemList containers/docker/TestJcmd.java on linux-x64
  • a3223cb: 8283999: Update JMH devkit to 1.35
  • e8e9b8d: 8282926: AArch64: Optimize out WHILELO with PTRUE
  • ... and 87 more: https://git.openjdk.java.net/jdk/compare/0ee65e1ff3eaed4a8a2542562f0ba2a61d0f5894...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2022
@naotoj
Copy link
Member Author

naotoj commented Mar 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

Going to push as commit a41550b.
Since your change was applied there have been 120 commits pushed to the master branch:

  • 207b099: 8283890: Changes in CFG file format break C1Visualizer
  • 49fcc7a: 8283013: Simplify Arguments::parse_argument()
  • 73cb922: 8284026: Use unmodifiable collections where practical
  • 77a205a: 8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile
  • 64025b0: 8283901: Introduce "make doctor" to diagnose build environment problems
  • 5740a3b: 8280193: summary javadoc for java.awt.GraphicsEnvironment#preferProportionalFonts broken
  • a11cc97: 8283997: Unused argument in GraphKit::builtin_throw
  • 067b258: 8224977: [macos] On AquaLookAndFeel, Iconified JInternalFrame does not restore when Control + F5 is used.
  • 0a9a7b6: 8283642: JavaDoc of JFileChooser() need to be updated for default directory in Windows
  • 1a5f5da: 8283996: Reduce cost of year and month calculations
  • ... and 110 more: https://git.openjdk.java.net/jdk/compare/0ee65e1ff3eaed4a8a2542562f0ba2a61d0f5894...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 31, 2022
@openjdk openjdk bot closed this Mar 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@naotoj Pushed as commit a41550b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants