Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c #8050

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 31, 2022

Please review this small patch to fix possibly leak of pVITrue.

Test:

  • jdk_awt

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8050/head:pull/8050
$ git checkout pull/8050

Update a local copy of the PR:
$ git checkout pull/8050
$ git pull https://git.openjdk.java.net/jdk pull/8050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8050

View PR using the GUI difftool:
$ git pr show -t 8050

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8050.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@zhengyu123 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 31, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2022

Webrevs

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how did you find this bug?

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • 36b9baa: 8282508: Updating ASM to 9.2 for JDK 19
  • 4e20a03: 8283044: Use asynchronous handshakes to deliver asynchronous exceptions
  • 9d200d6: 8282756: Make ElementKind checks more specific
  • 1012d59: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters
  • 003ec21: 8279508: Auto-vectorize Math.round API
  • c1e67b6: 8283474: Include detailed heap object info in CDS map file
  • 060a188: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension
  • e5e1aab: 8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state
  • 0b09f70: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • afd0f5a: 8284190: disable G1RegionToSpaceMapper.largeStressAdjacent_vm on windows
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/720e751f35150251cab05bc9fca3add39daf70af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 31, 2022
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 31, 2022

I wonder how did you find this bug?

Thanks for the review, @mrserb .

I use valgrind for detecting memory leak. JFC demos are good applications to exercise awt/2d/swing stacks.

@zhengyu123
Copy link
Contributor Author

Thanks, @mrserb @prrace

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

Going to push as commit 36b3bbc.
Since your change was applied there have been 68 commits pushed to the master branch:

  • 59fe31a: 8284170: Add "make doctor" to the make help
  • 9440b39: 8283215: [macos] Screen Magnifier: Getting java.awt.IllegalComponentStateException when menu item is selected
  • 86caf60: 8283703: Add sealed modifier to java.awt.geom.Path2D
  • 0cd46f6: 8283597: [REDO] Invalid generic signature for redefined classes
  • e297074: 8284181: ArgumentsTest.set_numeric_flag_double_vm fails on some locales
  • 732f7ae: 8284071: Collapse identical catch branches in jdk.console
  • 61d06c2: 8276050: XMLInputFactoryImpl.getProperty() returns null
  • 7381868: 8283623: Create an automated regression test for JDK-4525475
  • f76f5da: 5087440: java.io bulk read(...) end-of-stream return value descriptions ambiguous
  • 36b9baa: 8282508: Updating ASM to 9.2 for JDK 19
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/720e751f35150251cab05bc9fca3add39daf70af...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2022
@openjdk openjdk bot closed this Apr 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2022
@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@zhengyu123 Pushed as commit 36b3bbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants