JDK-8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state

[RealFYang]

For RISCV, we use membars when accessing volatile _thread_state through Atomic::load_acquire in JavaThread::thread_state.
Accordingly, we should use Atomic::release_store to access volatile _thread_state in JavaThread::set_thread_state.
This is correct for our internal JDK 11 distribution: both functions are guarded by a single-line macro check for architectures [1].

The code is refactored in JDK mainline: each function has their own architecture macro check.
But looks like we only kept the macro check for RISCV64 in JavaThread::thread_state when porting from JDK 11.
The same check is missing for JavaThread::set_thread_state. We should add it back.

Tested with hotspot tier1 & jdk tier1 on Linux-riscv64 board. No new errors witnessed.
Note that this will only affect the RISCV architecture.

[1] https://gitee.com/openeuler/bishengjdk-11/blob/risc-v/src/hotspot/share/runtime/thread.inline.hpp#L123

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8055/head:pull/8055
$ git checkout pull/8055

Update a local copy of the PR:
$ git checkout pull/8055
$ git pull https://git.openjdk.java.net/jdk pull/8055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8055

View PR using the GUI difftool:
$ git pr show -t 8055

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8055.diff

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (197116db)

[shipilev]

Looks fine and trivial.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 9156c0b: 8274148: can jshell show deprecated classes, methods and fields as strikethrough text?
• bab431c: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings
• 8eff806: 8284116: Rename serializePropertiesToByteArray_signature
• 38df570: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10
• ad83ec7: 8283422: Create a new test for JDK-8254790
• 6ebf845: 8283566: G1: Improve G1BarrierSet::enqueue performance
• d276da5: 8281469: aarch64: Improve interpreter stack banging
• a41550b: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException
• 207b099: 8283890: Changes in CFG file format break C1Visualizer
• 49fcc7a: 8283013: Simplify Arguments::parse_argument()
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/1a5f5da0502d056388b8390b008a4ff0d22faf92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

Looks fine and trivial.

Thank you. Since this will only affect riscv, I think it's safe for integration.
/integrate

[openjdk]

Going to push as commit e5e1aab.
Since your change was applied there have been 27 commits pushed to the master branch:

• 0b09f70: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
• afd0f5a: 8284190: disable G1RegionToSpaceMapper.largeStressAdjacent_vm on windows
• 028fbf4: 8254935: Deprecate the PSSParameterSpec(int) constructor
• 1dfa1ea: 8284094: Memory leak in invoker_completeInvokeRequest()
• 943d4ee: 8284180: Some files missing newlines
• 96179c8: 8284146: Disable jdk/jshell/HighlightUITest.java on macosx-aarch64
• 63fec5d: 8283525: http://tools.ietf.org/html/* URLs return 404
• dbfac3c: 8283269: Improve definition and use of jdk.javadoc.internal.doclets.toolkit.Content
• fc7a17c: 8284103: AsVarargsCollector::asCollectorCache incorrectly marked @stable
• 05ea7a5: 8282431: AArch64: Add optimized rules for masked vector multiply-add/sub for SVE
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/1a5f5da0502d056388b8390b008a4ff0d22faf92...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit e5e1aab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.