8284094: Memory leak in invoker_completeInvokeRequest()

[rkennke]

In invoker.c in the function invoker_completeInvokeRequest(), we allocate a PacketOutputStream object called out using outStream_initReply(), but never reclaim it. We need to call outStream_destroy() before going out of scope.

Testing:

• com/sun/jdi
• vmTestbase/nsk/jdi
• vmTestbase/nsk/jdb
• vmTestbase/nsk/jdwp
• tier1
• tier2
• tier3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284094: Memory leak in invoker_completeInvokeRequest()

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8059/head:pull/8059
$ git checkout pull/8059

Update a local copy of the PR:
$ git checkout pull/8059
$ git pull https://git.openjdk.java.net/jdk pull/8059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8059

View PR using the GUI difftool:
$ git pr show -t 8059

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8059.diff

[bridgekeeper]

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rkennke The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dcb92163)

[plummercj]

Looks good. Please add nsk/jdb and nsk/jdwp to your testing.

[openjdk]

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284094: Memory leak in invoker_completeInvokeRequest()

Reviewed-by: cjplummer, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 05ea7a5: 8282431: AArch64: Add optimized rules for masked vector multiply-add/sub for SVE
• 9156c0b: 8274148: can jshell show deprecated classes, methods and fields as strikethrough text?
• bab431c: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings
• 8eff806: 8284116: Rename serializePropertiesToByteArray_signature
• 38df570: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10
• ad83ec7: 8283422: Create a new test for JDK-8254790
• 6ebf845: 8283566: G1: Improve G1BarrierSet::enqueue performance
• d276da5: 8281469: aarch64: Improve interpreter stack banging
• a41550b: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException
• 207b099: 8283890: Changes in CFG file format break C1Visualizer
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/5740a3b6e635456b34b4f31d0f1e84d3e746b796...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rkennke]

/integrate

[openjdk]

Going to push as commit 1dfa1ea.
Since your change was applied there have been 19 commits pushed to the master branch:

• 943d4ee: 8284180: Some files missing newlines
• 96179c8: 8284146: Disable jdk/jshell/HighlightUITest.java on macosx-aarch64
• 63fec5d: 8283525: http://tools.ietf.org/html/* URLs return 404
• dbfac3c: 8283269: Improve definition and use of jdk.javadoc.internal.doclets.toolkit.Content
• fc7a17c: 8284103: AsVarargsCollector::asCollectorCache incorrectly marked @stable
• 05ea7a5: 8282431: AArch64: Add optimized rules for masked vector multiply-add/sub for SVE
• 9156c0b: 8274148: can jshell show deprecated classes, methods and fields as strikethrough text?
• bab431c: 8282429: StringBuilder/StringBuffer.toString() skip compressing for UTF16 strings
• 8eff806: 8284116: Rename serializePropertiesToByteArray_signature
• 38df570: 8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10
• ... and 9 more: https://git.openjdk.java.net/jdk/compare/5740a3b6e635456b34b4f31d0f1e84d3e746b796...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rkennke Pushed as commit 1dfa1ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.