Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255049: Remove support for the hsdis decode_instructions entry point in hotspot #807

Closed
wants to merge 3 commits into from

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented Oct 22, 2020

This patch drops support in hotspot for hsdis plugins which only include the old decode_instructions endpoint.

The decode_instructions entry point in hsdis was replaced by decode_instructions_virtual[1], with support later added to allow old hsdis plugins to work, at least for the duration of JDK 8. Dropping the backwards compatibility means you'll need a hsdis built from JDK 8 sources or later, which seems a reasonable requirement at this point.

It's unclear if a CSR request is needed.

[1] 22544e7
[2] a9c40e9


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8255049: Remove support for the hsdis decode_instructions entry point in hotspot

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/807/head:pull/807
$ git checkout pull/807

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2020

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@cl4es The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2020

Webrevs

Loading

Copy link
Contributor

@neliasso neliasso left a comment

Nice clean up.

Reviewed.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255049: Remove support for the hsdis decode_instructions entry point in hotspot

Reviewed-by: neliasso, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
  • f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
  • 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 22, 2020
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Loading

@cl4es
Copy link
Member Author

@cl4es cl4es commented Oct 23, 2020

@neliasso @vnkozlov - thanks for reviewing!

/integrate

Loading

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@cl4es Since your change was applied there have been 13 commits pushed to the master branch:

  • c1524c5: 8255208: CodeStrings passed to Disassembler::decode are ignored
  • 8e5dff0: 8255213: Shenandoah build fails without JFR after JDK-8255036
  • fe74f3c: 8255224: x86_32 tests fail with "bad AD file" after JDK-8223051
  • 64dc4b1: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution
  • a824781: 8255210: [Vector API] jdk/incubator/vector/Int256VectorTests.java crashes on AVX512 machines
  • 2ca7a08: 8255268: 32-bit failures in runtime/Metaspace/elastic
  • d8d9197: 8242559: Clean the "libawt_xawt" library from code for headless mode
  • ff5f226: 8255086: Update the root locale display names
  • 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
  • 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/cc50c8d4f18fb04a5d7b608d1cb250c1b3fd8690...master

Your commit was automatically rebased without conflicts.

Pushed as commit 107fb9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@cl4es cl4es deleted the cleanup_hsdis_entrypoints branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants