Skip to content

8284288: Use SVG images for FocusSpec.html and Modality.html#8091

Closed
aivanov-jdk wants to merge 1 commit intoopenjdk:masterfrom
aivanov-jdk:8284288-focus-svg
Closed

8284288: Use SVG images for FocusSpec.html and Modality.html#8091
aivanov-jdk wants to merge 1 commit intoopenjdk:masterfrom
aivanov-jdk:8284288-focus-svg

Conversation

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Apr 4, 2022

Both FocusSpec.html and Modality.html use GIF images for diagrams. The images look jagged, especially on High DPI screens which are common now. The images in Modality.html use dithered colours which don't look sharp even on regular displays.

All the modern browsers support SVG which is a vector format and therefore it always looks sharp.

You can view how the files look after being processed by javadoc:


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284288: Use SVG images for FocusSpec.html and Modality.html

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8091/head:pull/8091
$ git checkout pull/8091

Update a local copy of the PR:
$ git checkout pull/8091
$ git pull https://git.openjdk.java.net/jdk pull/8091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8091

View PR using the GUI difftool:
$ git pr show -t 8091

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8091.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 4, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2022

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284288: Use SVG images for FocusSpec.html and Modality.html

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2022
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit bbe894f.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@aivanov-jdk Pushed as commit bbe894f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8284288-focus-svg branch June 17, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants