8284288: Use SVG images for FocusSpec.html and Modality.html#8091
8284288: Use SVG images for FocusSpec.html and Modality.html#8091aivanov-jdk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
|
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit bbe894f.
Your commit was automatically rebased without conflicts. |
|
@aivanov-jdk Pushed as commit bbe894f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Both
FocusSpec.htmlandModality.htmluse GIF images for diagrams. The images look jagged, especially on High DPI screens which are common now. The images inModality.htmluse dithered colours which don't look sharp even on regular displays.All the modern browsers support SVG which is a vector format and therefore it always looks sharp.
You can view how the files look after being processed by javadoc:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8091/head:pull/8091$ git checkout pull/8091Update a local copy of the PR:
$ git checkout pull/8091$ git pull https://git.openjdk.java.net/jdk pull/8091/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8091View PR using the GUI difftool:
$ git pr show -t 8091Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8091.diff