Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator #810

Closed
wants to merge 3 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Oct 22, 2020

Hi,

Could someone please review my doc-only fix for JDK-8253473: 'Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator ' ?

This fix is set of formatting changes intended to clean up the javadoc of the following classes :

com.sun.net.httpserver.HttpHandler
com.sun.net.httpserver.HttpPrincipal
com.sun.net.httpserver.HttpContext
com.sun.net.httpserver.HttpsConfigurator

This issue is a sub-task of JDK-8252822

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/810/head:pull/810
$ git checkout pull/810

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2020

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2020
@openjdk
Copy link

openjdk bot commented Oct 22, 2020

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 22, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2020

Webrevs

@dfuch
Copy link
Member

dfuch commented Oct 29, 2020

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 29, 2020
@openjdk
Copy link

openjdk bot commented Oct 29, 2020

@dfuch has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@pconcannon please create a CSR request and add link to it in JDK-8253473. This pull request cannot be integrated until the CSR request is approved.

dfuch
dfuch approved these changes Oct 29, 2020
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 30, 2020
@openjdk
Copy link

openjdk bot commented Oct 30, 2020

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 379ba80: 8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait
  • 1a89d68: 8255285: Move JVMFlag origins into a new enum JVMFlagOrigin
  • 56eb5f5: 8255466: C2 crashes at ciObject::get_oop() const+0x0
  • 5782a2a: 8254975: lambda proxy fails to access a protected member inherited from a split package
  • d5138d1: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect
  • 2a2fa13: 8255449: Improve the exception message of MethodHandles::permuteArguments
  • 2a50c3f: 8241495: Make more compiler related flags available on a per method level
  • 5c520c3: 8255232: G1: Make G1BiasedMappedArray freeable
  • 9e5bbff: 8255550: x86: Assembler::cmpq(Address dst, Register src) encoding is incorrect
  • 5b18558: 8255243: Reinforce escape barrier interactions with ZGC conc stack processing
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/ea26ff1142b6b7413f01d83375ff3be8a3ab3e74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2020
@pconcannon
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2020
@openjdk
Copy link

openjdk bot commented Oct 30, 2020

@pconcannon Since your change was applied there have been 14 commits pushed to the master branch:

  • 379ba80: 8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait
  • 1a89d68: 8255285: Move JVMFlag origins into a new enum JVMFlagOrigin
  • 56eb5f5: 8255466: C2 crashes at ciObject::get_oop() const+0x0
  • 5782a2a: 8254975: lambda proxy fails to access a protected member inherited from a split package
  • d5138d1: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect
  • 2a2fa13: 8255449: Improve the exception message of MethodHandles::permuteArguments
  • 2a50c3f: 8241495: Make more compiler related flags available on a per method level
  • 5c520c3: 8255232: G1: Make G1BiasedMappedArray freeable
  • 9e5bbff: 8255550: x86: Assembler::cmpq(Address dst, Register src) encoding is incorrect
  • 5b18558: 8255243: Reinforce escape barrier interactions with ZGC conc stack processing
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/ea26ff1142b6b7413f01d83375ff3be8a3ab3e74...master

Your commit was automatically rebased without conflicts.

Pushed as commit d128191.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pconcannon pconcannon deleted the JDK-8253473 branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants