Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284316 : Support accessibility ManualTestFrame.java for non SwingSet tests #8100

Closed
wants to merge 4 commits into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Apr 4, 2022

  1. Modified ManualTestFrame.java to support non SwingSet2 and this include modification of SwingSetTest.java
  2. Added new TestJProgressBarAccessibility.java testcase that uses ManualTestFrame
  3. Added timeout support in case user does not interact with the ManualTestFrame

@shurymury
@azuev-java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

  • JDK-8284316: Support accessibility ManualTestFrame.java for non SwingSet tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8100/head:pull/8100
$ git checkout pull/8100

Update a local copy of the PR:
$ git checkout pull/8100
$ git pull https://git.openjdk.java.net/jdk pull/8100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8100

View PR using the GUI difftool:
$ git pr show -t 8100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8100.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2022

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@lawrence-andrew The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 4, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2022

Webrevs

@lawrence-andrew lawrence-andrew changed the title 8284316 : Support accessibility ManualTestFrame.java for non SwingSet2 tests 8284316 : Support accessibility ManualTestFrame.java for non SwingSet tests Apr 5, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 7, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2022
@shurymury
Copy link
Contributor

LGTM

@openjdk
Copy link

openjdk bot commented May 3, 2022

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284316: Support accessibility ManualTestFrame.java for non SwingSet tests

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 352 new commits pushed to the master branch:

  • 0f62cb6: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 6fcd322: 8279622: C2: miscompilation of map pattern as a vector reduction
  • af1ee1c: 8283684: IGV: speed up filter application
  • 7a48351: 8280568: IGV: Phi inputs and pinned nodes are not scheduled correctly
  • 64b5b2b: 8282828: CDS uncompressed oops archive is not deterministic
  • 45ca81f: 8285915: failure_handler: gather the contents of /etc/hosts file
  • 3420a1a: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • fbcd874: 8285979: G1: G1SegmentedArraySegment::header_size() is incorrect since JDK-8283368
  • 50a4df8: 8286024: PKCS12 keystore shows "DES/CBC" as the algorithm of a DES SecretKeyEntry
  • f973b78: 8286028: Some -Xlint keys are missing in javac man page
  • ... and 342 more: https://git.openjdk.java.net/jdk/compare/59fe31a0900f6ae2cf3846d11b623e287b61bb43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 3, 2022
@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 3, 2022
@openjdk
Copy link

openjdk bot commented May 3, 2022

@lawrence-andrew
Your change (at version 9d49e5b) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented May 9, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 9, 2022

Going to push as commit 6a7c023.
Since your change was applied there have been 433 commits pushed to the master branch:

  • 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
  • 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 397d095: 8285743: Ensure each IntegerPolynomial object is only created once
  • 29ccb8f: 8285914: AppCDS crash when using shared archive with old class file
  • fe6e0c0: 8286371: Avoid use of deprecated str[n]icmp
  • 97a9835: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]
  • 034f20f: 8212136: Remove finalizer implementation in SSLSocketImpl
  • 36e4df9: 8285516: clearPassword should be called in a finally try block
  • b849efd: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • f143386: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • ... and 423 more: https://git.openjdk.java.net/jdk/compare/59fe31a0900f6ae2cf3846d11b623e287b61bb43...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2022
@openjdk openjdk bot closed this May 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

@prrace @lawrence-andrew Pushed as commit 6a7c023.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants