8284331: Add sanity check for signal handler modification warning.

[kevinjwalls]

A sanity check using "jcmd VM.info" to catch the signal handler modification warning: it should never trigger during this test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284331: Add sanity check for signal handler modification warning.

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8106/head:pull/8106
$ git checkout pull/8106

Update a local copy of the PR:
$ git checkout pull/8106
$ git pull https://git.openjdk.java.net/jdk pull/8106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8106

View PR using the GUI difftool:
$ git pr show -t 8106

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8106.diff

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ea6a1aff)

[kevinjwalls]

(adding a note to trigger email notification, as that appears lost...)

[AlanBateman]

/label remove core-libs

[openjdk]

@AlanBateman
The core-libs label was successfully removed.

[dholmes-ora]

Seems quite reasonable.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284331: Add sanity check for signal handler modification warning.

Reviewed-by: dholmes, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 297 new commits pushed to the master branch:

• 573eace: 8285504: Minor cleanup could be done in javax.net
• bba456a: 8285676: Add missing @param tags for type parameters on classes and interfaces
• b9d1e85: 8285785: CheckCleanerBound test fails with PasswordCallback object is not released
• b718578: 8285011: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java fails after JDK-8280761
• 2d8d140: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
• ea83b44: 8280510: AArch64: Vectorize operations with loop induction variable
• 36bf6fb: 8285728: Alpine Linux build fails with busybox tar
• 091637c: 8285630: Fix a configure error in RISC-V cross build
• ccf0e8b: 8285755: JDK-8285093 changed the default for --with-output-sync
• d7514b0: 8285595: Assert frame anchor doesn't change in safepoints/handshakes
• ... and 287 more: https://git.openjdk.java.net/jdk/compare/632825c6d2933c8f1e63569199413ecaa74b6740...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

How does this relate the failure in JDK-8285647? Is this just meant to detect that failure, but a proper fix is still needed for it?

[kevinjwalls]

How does this relate the failure in JDK-8285647? Is this just meant to detect that failure, but a proper fix is still needed for it?

..it's not directly related - I had this test addition in progress already, as an addition to JDK-8283337 which fixes the modification handler being broken by a previous change (the warning was firing all the time, after JDK-8279124 and before JDK-8283337). So we should have a sanity check (this PR) which fails if the warning starts firing unnecessarily.

Logged JDK-8285792 to signal that we need some more cleanup here, including the news that I think JDK-8285647 shows that we don't consistently ignore the crash_handler.

[plummercj]

ok

[kevinjwalls]

thanks David and Alex and Chris 8-)

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 116763c.
Since your change was applied there have been 323 commits pushed to the master branch:

• 95d38bb: 8285773: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
• cd8709e: 8284883: JVM crash: guarantee(sect->end() <= sect->limit()) failed: sanity on AVX512
• 3d07b3c: 8282227: Locale information for nb is not working properly
• cfe67af: 8285938: ProblemList jdk/jshell/HighlightUITest.java on linux-x64
• 67dd8a8: 8285686: Upgrade to FreeType 2.12.0
• 64225e1: 8285919: Remove debug printout from JDK-8285093
• df4d5cf: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
• 694556e: 8225433: Clarify behavior of PKIXParameters.setRevocationEnabled when PKIXRevocationChecker is used
• e98ac23: 8285793: C2: optimization of mask checks in counted loops fail in the presence of cast nodes
• 669ac61: 8274597: Some of the dnd tests time out and fail intermittently
• ... and 313 more: https://git.openjdk.java.net/jdk/compare/632825c6d2933c8f1e63569199413ecaa74b6740...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 116763c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.