8255224: x86_32 tests fail with "bad AD file" after JDK-8223051

[rwestrel]

x86_32 is missing an ad file rule for (CMoveL (Bool (CmpUL

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x32	Linux x64	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)		✔️ (9/9 passed)	❌ (1/9 failed)	✔️ (9/9 passed)

Failed test task

• Windows x64 (hs/tier1 compiler)

Issue

• JDK-8255224: x86_32 tests fail with "bad AD file" after JDK-8223051

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/811/head:pull/811
$ git checkout pull/811

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a38e33a)

[shipilev]

So these are the copies of cmovLL_reg_LEGT and cmovLL_mem_LEGT matches above, but with flagsReg_ulong_LEGT flags? Looks fine to me. It passes almost all tests in tier1 for me (other failures look unrelated).

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255224: x86_32 tests fail with "bad AD file" after JDK-8223051

Reviewed-by: shade, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
• f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
• 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended
• cc50c8d: 8255196: Remove unused G1FullGCCompactionPoint::merge()
• ae72b52: 8255047: Add HotSpot UseDebuggerErgo flags
• 211bb62: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonitorStateException: current thread is not owner
• 299e115: 8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5
• a5b7bc5: 7156347: javax/swing/JList/6462008/bug6462008.java fails
• b25d894: 8252204: AArch64: Implement SHA3 accelerator/intrinsic
• 7d3d4da: 8240709: Enable javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java on all L&F
• ... and 65 more: https://git.openjdk.java.net/jdk/compare/294e0705faf40e8fe5989a19f464c0739790e7e3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rwestrel]

@vnkozlov @shipilev thanks for the review

[rwestrel]

/integrate

[openjdk]

@rwestrel Since your change was applied there have been 82 commits pushed to the master branch:

• 64dc4b1: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution
• a824781: 8255210: [Vector API] jdk/incubator/vector/Int256VectorTests.java crashes on AVX512 machines
• 2ca7a08: 8255268: 32-bit failures in runtime/Metaspace/elastic
• d8d9197: 8242559: Clean the "libawt_xawt" library from code for headless mode
• ff5f226: 8255086: Update the root locale display names
• 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
• 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag
• a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
• f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
• 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended
• ... and 72 more: https://git.openjdk.java.net/jdk/compare/294e0705faf40e8fe5989a19f464c0739790e7e3...master

Your commit was automatically rebased without conflicts.

Pushed as commit fe74f3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.