Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284368: Remove finalizer method in jdk.crypto.cryptoki #8112

Closed
wants to merge 2 commits into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Apr 5, 2022

Please review the update to remove finalizer method in the jdk.crypto.cryptoki module. It is one of the efforts to clean up the use of finalizer method in JDK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284368: Remove finalizer method in jdk.crypto.cryptoki

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8112/head:pull/8112
$ git checkout pull/8112

Update a local copy of the PR:
$ git checkout pull/8112
$ git pull https://git.openjdk.java.net/jdk pull/8112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8112

View PR using the GUI difftool:
$ git pr show -t 8112

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8112.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 5, 2022
@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Apr 5, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2022

Webrevs

Copy link

@valeriepeng valeriepeng left a comment

Looks good. Thanks!

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284368: Remove finalizer method in jdk.crypto.cryptoki

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 741be46: 8183390: Fix and re-enable post loop vectorization
  • 500f9a5: 8283396: Null pointer dereference in loopnode.cpp:2851
  • e9e3aa7: 8283730: Improve discussion of modeling of packages and modules
  • 20acea4: 8284362: Remove the "unsupported API" warning from jdk.javadoc
  • ff1daa8: 8284380: ProblemList jdk/jshell/HighlightUITest.java on more platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 6, 2022
@XueleiFan
Copy link
Member Author

XueleiFan commented Apr 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit 77388ea.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 8e4fab0: 8284303: runtime/Thread/AsyncExceptionTest.java timed out
  • 3cd3a83: 8284167: Make internal javac exceptions stackless
  • a385142: 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method
  • ec205f6: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • b9cc3bc: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt
  • bbe894f: 8284288: Use SVG images for FocusSpec.html and Modality.html
  • e524107: 8280872: Reorder code cache segments to improve code density
  • e18414a: 8284014: Menu items with submenus in JPopupMEnu are not spoken on macOS
  • b56df28: 8283935: Parallel: Crash during pretouch after large pages allocation failure
  • 0a67d68: 8284294: Create an automated regression test for RFE 4138746
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/526e73498eef5c7608845501ab4ebef0997a5c0d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready rfr labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@XueleiFan Pushed as commit 77388ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8284368 branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants