New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284368: Remove finalizer method in jdk.crypto.cryptoki #8112
Conversation
|
@XueleiFan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@XueleiFan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit 77388ea.
Your commit was automatically rebased without conflicts. |
@XueleiFan Pushed as commit 77388ea. |
Please review the update to remove finalizer method in the jdk.crypto.cryptoki module. It is one of the efforts to clean up the use of finalizer method in JDK.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8112/head:pull/8112
$ git checkout pull/8112
Update a local copy of the PR:
$ git checkout pull/8112
$ git pull https://git.openjdk.java.net/jdk pull/8112/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8112
View PR using the GUI difftool:
$ git pr show -t 8112
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8112.diff