8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer #8113
You're right. I'll do another PR to update the actions versions. There are also updates possible for upload and donwload actions.
Yeah, I wasn't happy with this, too. I, however, thought that we could maybe assume that the build step was run successfully before the test step and therefore the cygwin installer should be in the cache and we would never fail. But, I guess you're right, the cache could be evicted in between due to whatever reason and we're unnecessarily abstaining from a safety net.
What I want to accomplish is that if it fails due to an issue with downloading the cygwin installer, it should fail in the build job, not later. But this should be the case in 99.99% now anyway, due to the added caching.
I will implement your suggestions.
@RealCLanger This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
➡️ To integrate this PR with the above commit message to the
Going to push as commit 61fcf2f.
Your commit was automatically rebased without conflicts.