Skip to content

8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4 #8118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 6, 2022

Trivial fix that adds a missing @requires to guard against the case when C2 is not available (for example, when TieredStopAtLevel < 4).

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8118/head:pull/8118
$ git checkout pull/8118

Update a local copy of the PR:
$ git checkout pull/8118
$ git pull https://git.openjdk.java.net/jdk pull/8118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8118

View PR using the GUI difftool:
$ git pr show -t 8118

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8118.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 6, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2022

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial!

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 6, 2022
@TobiHartmann
Copy link
Member Author

Thanks, Christian!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit 955d61d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4ffe96a: 8282506: Clean up remaining references to TwoStacksPlain*SocketImpl

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@TobiHartmann Pushed as commit 955d61d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants