Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284378: Make Metal the default Java 2D rendering pipeline for macOS #8121

Closed
wants to merge 1 commit into from

Conversation

aghaisas
Copy link
Contributor

@aghaisas aghaisas commented Apr 6, 2022

This PR makes Metal rendering pipeline as the default Java 2D rendering pipeline for macOS.

Please refer "JBS Description" for more details.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8284378: Make Metal the default Java 2D rendering pipeline for macOS
  • JDK-8284379: Make Metal the default Java 2D rendering pipeline for macOS (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8121/head:pull/8121
$ git checkout pull/8121

Update a local copy of the PR:
$ git checkout pull/8121
$ git pull https://git.openjdk.java.net/jdk pull/8121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8121

View PR using the GUI difftool:
$ git pr show -t 8121

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8121.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2022

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@aghaisas The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 6, 2022
@aghaisas
Copy link
Contributor Author

aghaisas commented Apr 6, 2022

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@aghaisas this pull request will not be integrated until the CSR request JDK-8284379 for issue JDK-8284378 has been approved.

@mlbridge
Copy link

mlbridge bot commented Apr 6, 2022

Webrevs

Copy link
Contributor

@avu avu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (committer)

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 8, 2022
@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284378: Make Metal the default Java 2D rendering pipeline for macOS

Reviewed-by: kcr, avu, prr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • e572a52: 8280511: AArch64: Combine shift and negate to a single instruction
  • de9596c: 8284495: [testbug] Adapt nsk tests to the RISC-V platform
  • d4a4884: 8284458: CodeHeapState::aggregate() leaks blob_name
  • e98c32d: 8284043: com/sun/jdi/MethodInvokeWithTraceOnTest.java failing with com.sun.jdi.ObjectCollectedException
  • 343e5f0: 8282040: Remove unnecessary check made obsolete by JDK-8261941
  • d6f01e9: 8234128: jarsigner will not show not-signed-by-alias warning if an intermediate cert is in this keystore
  • 5bafcfd: 8284444: Sting typo
  • ec73c61: 8284353: Update java/net and sun/net/www tests to eliminate dependency on sun.net.www.MessageHeader
  • 8e58d4a: 8284415: Collapse identical catch branches in security libs
  • 4f36229: 8284446: Miscellaneous doc-comment fixes in jdk.javadoc
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/741be46138c4a02f1d9661b3acffb533f50ba9cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2022
@aghaisas
Copy link
Contributor Author

aghaisas commented Apr 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

Going to push as commit 3a0ddeb.
Since your change was applied there have been 37 commits pushed to the master branch:

  • b55c32f: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler
  • 8eac342: 8284507: GHA: Only check test results if testing was not skipped
  • 6028181: 8283930: IGV: add toggle button to show/hide empty blocks in CFG view
  • a445ecd: 8284297: Move FILE_AND_LINE to a platform independent header
  • 003aa2e: 8282043: IGV: speed up schedule approximation
  • 8c18705: 8284433: Cleanup Disassembler::find_prev_instr() on all platforms
  • e572a52: 8280511: AArch64: Combine shift and negate to a single instruction
  • de9596c: 8284495: [testbug] Adapt nsk tests to the RISC-V platform
  • d4a4884: 8284458: CodeHeapState::aggregate() leaks blob_name
  • e98c32d: 8284043: com/sun/jdi/MethodInvokeWithTraceOnTest.java failing with com.sun.jdi.ObjectCollectedException
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/741be46138c4a02f1d9661b3acffb533f50ba9cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2022
@openjdk openjdk bot closed this Apr 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2022
@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@aghaisas Pushed as commit 3a0ddeb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants