8284458: CodeHeapState::aggregate() leaks blob_name

[zhengyu123]

Please review this small patch to fix a possible memory leak.

Test:

• hotspot_serviceability

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284458: CodeHeapState::aggregate() leaks blob_name

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8132/head:pull/8132
$ git checkout pull/8132

Update a local copy of the PR:
$ git checkout pull/8132
$ git pull https://git.openjdk.java.net/jdk pull/8132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8132

View PR using the GUI difftool:
$ git pr show -t 8132

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8132.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (7519e2a9)
• 01: Full - Incremental (c49ec0bb)
• 00: Full (be802be7)

[RealLucy]

Looks good to me.
Good catch! Thanks for finding and fixing the leak.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284458: CodeHeapState::aggregate() leaks blob_name

Reviewed-by: lucy, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• e98c32d: 8284043: com/sun/jdi/MethodInvokeWithTraceOnTest.java failing with com.sun.jdi.ObjectCollectedException
• 343e5f0: 8282040: Remove unnecessary check made obsolete by JDK-8261941
• d6f01e9: 8234128: jarsigner will not show not-signed-by-alias warning if an intermediate cert is in this keystore
• 5bafcfd: 8284444: Sting typo
• ec73c61: 8284353: Update java/net and sun/net/www tests to eliminate dependency on sun.net.www.MessageHeader
• 8e58d4a: 8284415: Collapse identical catch branches in security libs
• 4f36229: 8284446: Miscellaneous doc-comment fixes in jdk.javadoc
• 1928865: 8284166: [macos] Replace deprecated alternateSelectedControlColor with selectedContentBackgroundColor
• 4d2cd26: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large
• 61fcf2f: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/77388eaf2595f5785bb0945ccecf84c4916031e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

/label add hotspot-serviceability

[zhengyu123]

/label remove hotspot-compiler

[openjdk]

@zhengyu123
The label hotspot-serviceability is not a valid label.
These labels are valid:

• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[openjdk]

@zhengyu123
The hotspot-compiler label was successfully removed.

[zhengyu123]

/label add serviceability

[openjdk]

@zhengyu123
The serviceability label was successfully added.

[zhengyu123]

Thanks for the review, @RealLucy

[zhengyu123]

Thanks, @lmesnik

[zhengyu123]

/integrate

[openjdk]

Going to push as commit d4a4884.
Since your change was applied there have been 15 commits pushed to the master branch:

• e98c32d: 8284043: com/sun/jdi/MethodInvokeWithTraceOnTest.java failing with com.sun.jdi.ObjectCollectedException
• 343e5f0: 8282040: Remove unnecessary check made obsolete by JDK-8261941
• d6f01e9: 8234128: jarsigner will not show not-signed-by-alias warning if an intermediate cert is in this keystore
• 5bafcfd: 8284444: Sting typo
• ec73c61: 8284353: Update java/net and sun/net/www tests to eliminate dependency on sun.net.www.MessageHeader
• 8e58d4a: 8284415: Collapse identical catch branches in security libs
• 4f36229: 8284446: Miscellaneous doc-comment fixes in jdk.javadoc
• 1928865: 8284166: [macos] Replace deprecated alternateSelectedControlColor with selectedContentBackgroundColor
• 4d2cd26: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large
• 61fcf2f: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/77388eaf2595f5785bb0945ccecf84c4916031e7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit d4a4884.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.