8284521: Write an automated regression test for JComponent.setRequestFocusEnabled()

[manukumarvs]

Write an automated regression test for JDK-4371575

Issue:
As part of the Merlin focus project, JComponent.setRequestFocusEnabled was
deprecated and its implementation was changed to map exactly to the new
method Component.setFocusable. Scott believes that the old behavior may be
preferable. He would like to be able to specify that a Component is focusable,
and should receive focus during keyboard traversal, but that it should not
automatically take focus when the user clicks on it with the mouse.

We are concerned that the accessibility team would be against this behavior,
and this also seems like more of a PLAF issue. Nevertheless, we should look
into it before beta ships.

Fix:
After some discussion we decided that the best balance of the old and new would be to make this an advisory property. This property will not be synonymous with focusable. Instead our mouse listeners will check this property before requesting focus. This provides as closely as possible the old behavior, while allowing people to use the new focusable property if they don't want a component focusable at all.

Testing:
Tested in mach5, 10 times with all the 3 available platform like macosx, windows and linux and got all Pass.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284521: Write an automated regression test for RFE 4371575

Reviewers

• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8143/head:pull/8143
$ git checkout pull/8143

Update a local copy of the PR:
$ git checkout pull/8143
$ git pull https://git.openjdk.java.net/jdk pull/8143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8143

View PR using the GUI difftool:
$ git pr show -t 8143

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8143.diff

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1f0e102f)
• 00: Full (79dd4c74)

[prrace]

Before I look at the test, can you get rid of the pointless directory 4371575
A directory might be needed if you had a lot of files for the test - but you don't !
And I really don't like naming directories OR tests with the bugid. Someone can find
that out from the @bug tag.

I know you've pushed a bunch of bugs already that follow this pattern but update all the "in progress" ones to NOT create pointless extra folders.

[manukumarvs]

Before I look at the test, can you get rid of the pointless directory 4371575 A directory might be needed if you had a lot of files for the test - but you don't ! And I really don't like naming directories OR tests with the bugid. Someone can find that out from the @bug tag.

I know you've pushed a bunch of bugs already that follow this pattern but update all the "in progress" ones to NOT create pointless extra folders.

I have removed those directories from this PR and from my other open PRs #7906 and #7996

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284521: Write an automated regression test for RFE 4371575

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 606 new commits pushed to the master branch:

• 37e28ae: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long
• 0b867b5: 8284330: jcmd may not be able to find processes in the container
• eab4c0c: 8283706: Add final or sealed modifier to appropriate javax.swing API classes
• 3357d9a: 8284588: Remove GensrcCommonLangtools.gmk
• a8c8752: 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java
• 662320a: 8284336: CDS SignedJar.java test fails due to archived Reference object
• 1bd8975: 8284361: Updating ASM to 9.3 for JDK 19
• 0a02675: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes
• d6b4693: 8283698: Refactor Locale constructors used in src/test
• 61698bd: 8284533: Improve InterpreterCodelet data footprint
• ... and 596 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version 1f0e102) is now ready to be sponsored by a Committer.

[manukumarvs]

@mrserb Can you sponsor this PR?

[akolarkunnu]

/sponsor

[openjdk]

Going to push as commit 447c2d1.
Since your change was applied there have been 690 commits pushed to the master branch:

• 145dfed: 8284937: riscv: should not allocate special register for temp
• 87faa85: 8186958: Need method to create pre-sized HashMap
• 41fc078: 8284112: Minor cleanup could be done in javax.crypto
• 897d6c0: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
• ffdeb32: 8284928: Add links from SourceVersion to specific JLS versions
• d3d71ea: 8284922: Fix some doc-comment issues on methods with package access in JDK API
• 6e36c45: 8284923: Update description of SourceVersion.RELEASE_18
• c63fabe: 8284935: Improve debug in java.security.jgss
• ef25e18: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de
• 21ea740: 8284699: Include all image types to the J2DBench.ColorConvertOpTests
• ... and 680 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@akolarkunnu @manukumarvs Pushed as commit 447c2d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.