Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284549: JFR: FieldTable leaks FieldInfoTable member #8149

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 7, 2022

FieldTable is a ResourceObj and it has a member points to FieldInfoTable, which is a CHeapObj.

Since ResouceObj's destructor is never called, so it can not depend on FieldTables destructor to free FieldInfoTable, it needs to be freed explicitly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284549: JFR: FieldTable leaks FieldInfoTable member

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8149/head:pull/8149
$ git checkout pull/8149

Update a local copy of the PR:
$ git checkout pull/8149
$ git pull https://git.openjdk.java.net/jdk pull/8149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8149

View PR using the GUI difftool:
$ git pr show -t 8149

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8149.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Apr 7, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2022

Webrevs

Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284549: JFR: FieldTable leaks FieldInfoTable member

Reviewed-by: mgronlun, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 37e28ae: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long
  • 0b867b5: 8284330: jcmd may not be able to find processes in the container
  • eab4c0c: 8283706: Add final or sealed modifier to appropriate javax.swing API classes
  • 3357d9a: 8284588: Remove GensrcCommonLangtools.gmk
  • a8c8752: 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java
  • 662320a: 8284336: CDS SignedJar.java test fails due to archived Reference object
  • 1bd8975: 8284361: Updating ASM to 9.3 for JDK 19
  • 0a02675: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes
  • d6b4693: 8283698: Refactor Locale constructors used in src/test
  • 61698bd: 8284533: Improve InterpreterCodelet data footprint
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/ec73c61d8fe5de15a42fc14aaf8ebe3ac9ffcae5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2022
@zhengyu123
Copy link
Contributor Author

Thanks for the review, @mgronlun

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Zhengyu,

overall ok. Small nits inline.

Cheers, Thomas

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zhengyu123
Copy link
Contributor Author

Thanks, @tstuefe

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2022

Going to push as commit 92f5e42.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 34914f1: 8284178: os::commit_memory() should assert the given range
  • 37e28ae: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long
  • 0b867b5: 8284330: jcmd may not be able to find processes in the container
  • eab4c0c: 8283706: Add final or sealed modifier to appropriate javax.swing API classes
  • 3357d9a: 8284588: Remove GensrcCommonLangtools.gmk
  • a8c8752: 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java
  • 662320a: 8284336: CDS SignedJar.java test fails due to archived Reference object
  • 1bd8975: 8284361: Updating ASM to 9.3 for JDK 19
  • 0a02675: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes
  • d6b4693: 8283698: Refactor Locale constructors used in src/test
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/ec73c61d8fe5de15a42fc14aaf8ebe3ac9ffcae5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2022
@openjdk openjdk bot closed this Apr 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2022
@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@zhengyu123 Pushed as commit 92f5e42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants