Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java #8152

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Apr 7, 2022

Tests are updated to ensure that classes are alive while test checks them.
Actually, fixed by @AlanBateman in repo-loom.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8152/head:pull/8152
$ git checkout pull/8152

Update a local copy of the PR:
$ git checkout pull/8152
$ git pull https://git.openjdk.java.net/jdk pull/8152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8152

View PR using the GUI difftool:
$ git pr show -t 8152

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8152.diff

…nClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2022

@lmesnik The following labels will be automatically applied to this pull request:

  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot-runtime labels Apr 7, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2022

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 8, 2022
@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Apr 8, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2022

Going to push as commit a8c8752.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 662320a: 8284336: CDS SignedJar.java test fails due to archived Reference object
  • 1bd8975: 8284361: Updating ASM to 9.3 for JDK 19
  • 0a02675: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes
  • d6b4693: 8283698: Refactor Locale constructors used in src/test
  • 61698bd: 8284533: Improve InterpreterCodelet data footprint
  • 3a0ddeb: 8284378: Make Metal the default Java 2D rendering pipeline for macOS
  • b55c32f: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler
  • 8eac342: 8284507: GHA: Only check test results if testing was not skipped
  • 6028181: 8283930: IGV: add toggle button to show/hide empty blocks in CFG view
  • a445ecd: 8284297: Move FILE_AND_LINE to a platform independent header
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/d4a48843856e3d80a58d5a0a26dff6c4d349dca9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 8, 2022
@openjdk openjdk bot closed this Apr 8, 2022
@openjdk openjdk bot removed ready rfr labels Apr 8, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2022

@lmesnik Pushed as commit a8c8752.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
2 participants