New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java #8152
Conversation
…nClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java
|
@lmesnik The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@lmesnik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Going to push as commit a8c8752.
Your commit was automatically rebased without conflicts. |
Tests are updated to ensure that classes are alive while test checks them.
Actually, fixed by @AlanBateman in repo-loom.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8152/head:pull/8152
$ git checkout pull/8152
Update a local copy of the PR:
$ git checkout pull/8152
$ git pull https://git.openjdk.java.net/jdk pull/8152/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8152
View PR using the GUI difftool:
$ git pr show -t 8152
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8152.diff