Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8255268: 32-bit failures in runtime/Metaspace/elastic #817

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 22, 2020

Hi,

may I please have reviews for this small test fix? This fixes the elastic metaspace tests on 32bit by increasing the alignment size (which is given in number of words) to a value valid for both 64bit and 32bit.

Tested: these tests, on 32bit and 64bit.

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8255268: 32-bit failures in runtime/Metaspace/elastic

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/817/head:pull/817
$ git checkout pull/817

@tstuefe tstuefe changed the title JDK-8255268 JDK-8255268: 32-bit failures in runtime/Metaspace/elastic Oct 22, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2020

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2020

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Thanks! Looks good and trivial to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255268: 32-bit failures in runtime/Metaspace/elastic

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
  • 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 22, 2020
@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Oct 23, 2020

Thanks! Looks good and trivial to me.

Thanks! Following the trivial rule I will now integrate without waiting.

Loading

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Oct 23, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@tstuefe Since your change was applied there have been 4 commits pushed to the master branch:

  • d8d9197: 8242559: Clean the "libawt_xawt" library from code for headless mode
  • ff5f226: 8255086: Update the root locale display names
  • 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
  • 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag

Your commit was automatically rebased without conflicts.

Pushed as commit 2ca7a08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@tstuefe tstuefe deleted the JDK-8255268-32bit-failures-elastic-metaspace-tests branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants