-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284620: CodeBuffer may leak _overflow_arena #8172
8284620: CodeBuffer may leak _overflow_arena #8172
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
@zhengyu123 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Another review would be good.
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks, @TobiHartmann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks, @vnkozlov |
/integrate |
Going to push as commit 4d45c3e.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 4d45c3e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
CodeBuffer
is declared asStackObj
, but it also hasResourceObj
stylenew operator
, to complicate thing further more, it has _overflow_arena that is C Heap allocated.When Stack allocated
CodeBuffer
owns_overflow_arena
, it works fine, because its destructor frees_overflow_arena
. But if resource allocatedCodeBuffer
owns_overflow_arena
, the arena is leaked, because its destructor is never called.Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8172/head:pull/8172
$ git checkout pull/8172
Update a local copy of the PR:
$ git checkout pull/8172
$ git pull https://git.openjdk.java.net/jdk pull/8172/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8172
View PR using the GUI difftool:
$ git pr show -t 8172
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8172.diff