Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284687: validate-source failure after JDK-8283710 #8181

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 11, 2022

A trivial copyright fix to solve validate-source failure after JDK-8283710.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284687: validate-source failure after JDK-8283710

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8181/head:pull/8181
$ git checkout pull/8181

Update a local copy of the PR:
$ git checkout pull/8181
$ git pull https://git.openjdk.java.net/jdk pull/8181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8181

View PR using the GUI difftool:
$ git pr show -t 8181

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8181.diff

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Apr 11, 2022

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 11, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284687: validate-source failure after JDK-8283710

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Apr 11, 2022

@irisclark - Thanks for the lightning fast review!

/integrate

@openjdk openjdk bot added ready rfr hotspot-runtime labels Apr 11, 2022
@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability label Apr 11, 2022
@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Apr 11, 2022

Going to push as commit 470a668.

@openjdk openjdk bot added the integrated label Apr 11, 2022
@openjdk openjdk bot closed this Apr 11, 2022
@openjdk openjdk bot removed ready rfr labels Apr 11, 2022
@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@dcubed-ojdk Pushed as commit 470a668.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 11, 2022

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8284687 branch Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
2 participants