-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284687: validate-source failure after JDK-8283710 #8181
Conversation
/label add hotspot-runtime |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@irisclark - Thanks for the lightning fast review! /integrate |
@dcubed-ojdk |
@dcubed-ojdk |
Going to push as commit 470a668. |
@dcubed-ojdk Pushed as commit 470a668. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A trivial copyright fix to solve validate-source failure after JDK-8283710.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8181/head:pull/8181
$ git checkout pull/8181
Update a local copy of the PR:
$ git checkout pull/8181
$ git pull https://git.openjdk.java.net/jdk pull/8181/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8181
View PR using the GUI difftool:
$ git pr show -t 8181
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8181.diff