New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8229845: Decrease memory consumption of BigInteger.toString() #819
Conversation
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A microbenchmark or something that summarizes the improvement and can verify that we don't regress on some variant would've been nice.
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@bplb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
What's the hold-up on this? |
/integrate |
@bplb Since your change was applied there have been 456 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2ae3e51. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this proposed fix. The review was initially in this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/061914.html
under the old Hg SCM. The changes proposed here are derived from the final (.05) patch in the previous review which was posted in
http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062012.html.
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/819/head:pull/819
$ git checkout pull/819