Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation #8200

Closed

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Apr 12, 2022

Adds an implementation of the missing method (guarded with defined(AARCH64) && defined(__APPLE__)) and fixes the compilation issues on Mac M1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8200/head:pull/8200
$ git checkout pull/8200

Update a local copy of the PR:
$ git checkout pull/8200
$ git pull https://git.openjdk.java.net/jdk pull/8200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8200

View PR using the GUI difftool:
$ git pr show -t 8200

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8200.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@parttimenerd The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 12, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

It seems apparent that nobody has been building Zero in this environment.

Thanks,
David

src/hotspot/os_cpu/bsd_zero/os_bsd_zero.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7891085: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 19b140a: 8283083: java.util.random L128X256MixRandom constructor fails to use byte[] seed
  • 3f26d84: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
  • a5378fb: 8284125: AArch64: Remove partial masked operations for SVE
  • 8346643: 8196465: javax/swing/JComboBox/8182031/ComboPopupTest.java fails on Linux
  • 5851631: 8284622: Update versions of some Github Actions used in JDK workflow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 12, 2022
@parttimenerd
Copy link
Contributor Author

Yes, it does. But I included it in my jdk-profiling-tester to find crashes causes by AsyncGetCallTrace.

@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@parttimenerd
Your change (at version fa7af7e) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

Going to push as commit bc12e86.
Since your change was applied there have been 7 commits pushed to the master branch:

  • cafde7f: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 7891085: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 19b140a: 8283083: java.util.random L128X256MixRandom constructor fails to use byte[] seed
  • 3f26d84: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
  • a5378fb: 8284125: AArch64: Remove partial masked operations for SVE
  • 8346643: 8196465: javax/swing/JComboBox/8182031/ComboPopupTest.java fails on Linux
  • 5851631: 8284622: Update versions of some Github Actions used in JDK workflow

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 12, 2022
@openjdk openjdk bot closed this Apr 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@dholmes-ora @parttimenerd Pushed as commit bc12e86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Mailing list message from Magnus Ihse Bursie on hotspot-runtime-dev:

On 2022-04-12 15:21, David Holmes wrote:

On Tue, 12 Apr 2022 11:31:03 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

Adds an implementation of the missing method (guarded with `defined(AARCH64) && defined(__APPLE__)`) and fixes the compilation issues on Mac M1.
Looks good and trivial.

It seems apparent that nobody has been building Zero in this environment.

I'm a bit surprised at this. I thought macos/aarch64 was added to GHA
some time ago? (And also to Oracle's internal CI pipeline)

/Magnus

@shipilev
Copy link
Member

I'm a bit surprised at this. I thought macos/aarch64 was added to GHA some time ago? (And also to Oracle's internal CI pipeline)

This is Zero-specific, note the compilation unit name :)

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Mailing list message from Thomas Stüfe on hotspot-runtime-dev:

Hi Magnus,

On Wed, Apr 13, 2022 at 1:23 PM Magnus Ihse Bursie <
magnus.ihse.bursie at oracle.com> wrote:

On 2022-04-12 15:21, David Holmes wrote:

On Tue, 12 Apr 2022 11:31:03 GMT, Johannes Bechberger <
duke at openjdk.java.net> wrote:

Adds an implementation of the missing method (guarded with
`defined(AARCH64) && defined(__APPLE__)`) and fixes the compilation issues
on Mac M1.
Looks good and trivial.

It seems apparent that nobody has been building Zero in this environment.
I'm a bit surprised at this. I thought macos/aarch64 was added to GHA
some time ago? (And also to Oracle's internal CI pipeline)

GHAs build Linux Zero (hotspot only). I think nobody builds MacOs zero, or?
This was a MacOs specific bug (still good to have that fixed though).

/Magnus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants