Skip to content

8194946: Regression automated Test 'javax/swing/JFileChooser/6738668/bug6738668.java' fails #8202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 12, 2022

Test was failing in CI system in nightly testing.
Saw it failed with HeadlessException in macos-x64 and mascos-aarch64 and with GTKL&F not supported in linux-x64 in headless CI system.
Made the test headful and test now passes in all platforms (link in JBS)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8194946: Regression automated Test 'javax/swing/JFileChooser/6738668/bug6738668.java' fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8202/head:pull/8202
$ git checkout pull/8202

Update a local copy of the PR:
$ git checkout pull/8202
$ git pull https://git.openjdk.java.net/jdk pull/8202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8202

View PR using the GUI difftool:
$ git pr show -t 8202

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8202.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 12, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8194946: Regression automated Test 'javax/swing/JFileChooser/6738668/bug6738668.java' fails

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 280aa42: 8284579: Improve VarHandle checks for interpreter
  • c355902: 8282528: AArch64: Incorrect replicate2L_zero rule
  • 5691a3b: 8284702: Add @SInCE for java.time.LocalDate.EPOCH
  • 7920e8b: 8283714: REDO - Unexpected TypeElement in ANALYZE TaskEvent
  • bc12e86: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • cafde7f: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 7891085: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 19b140a: 8283083: java.util.random L128X256MixRandom constructor fails to use byte[] seed
  • 3f26d84: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

⚠️ @prsadhuk This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

Going to push as commit 70251b0.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 507dc41: 8284720: IntelliJ: JIRA integration
  • 280aa42: 8284579: Improve VarHandle checks for interpreter
  • c355902: 8282528: AArch64: Incorrect replicate2L_zero rule
  • 5691a3b: 8284702: Add @SInCE for java.time.LocalDate.EPOCH
  • 7920e8b: 8283714: REDO - Unexpected TypeElement in ANALYZE TaskEvent
  • bc12e86: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • cafde7f: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • 7891085: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 19b140a: 8283083: java.util.random L128X256MixRandom constructor fails to use byte[] seed
  • 3f26d84: 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 13, 2022
@openjdk openjdk bot closed this Apr 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@prsadhuk Pushed as commit 70251b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8194946 branch April 13, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants