8254871: Remove unnecessary string copy in NetworkInterface.c

[e1iu]

A small improvement to avoid extra string copy.

[Tests]
Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
No new failure found.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254871: Remove unnecessary string copy in NetworkInterface.c

Reviewers

• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/821/head:pull/821
$ git checkout pull/821

[bridgekeeper]

👋 Welcome back erik1iu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erik1iu The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6bcb109)

[e1iu]

@kimbarrett Could you help to take look at this trivial patch?

[Michael-Mc-Mahon]

LGTM

[openjdk]

@erik1iu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254871: Remove unnecessary string copy in NetworkInterface.c

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

• 84e985d: 8253920: Share method trampolines in CDS dynamic archive
• 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
• 504cb00: 8252113: Move jfr man page into jfr module
• 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
• 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
• cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
• 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
• 7679650: 8231231: The printing result is different from the case instruction
• f7c59c6: 8255231: Avoid upcalls when initializing the statSampler
• dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
• ... and 87 more: https://git.openjdk.java.net/jdk/compare/2e510e04bd66c6d4bad0dcd51ebccf719defefa2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[msheppar]

In the original the copy would appear to be a way of enforcing that the supplied name is not greater than the max IF name size (IFNAMSIZ),
so in the updated version if limit >= IFNAMSIZ is there any point in performing the search? As it is unlikely to match a returned interface name ?

[e1iu]

/integrate

[openjdk]

@erik1iu
Your change (at version 6bcb109) is now ready to be sponsored by a Committer.

[nick-arm]

/sponsor

[openjdk]

@nick-arm @erik1iu Since your change was applied there have been 102 commits pushed to the master branch:

• acd0e25: 8255254: Split os::reserve_memory and os::map_memory_to_file interfaces
• dc85a3f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX
• 1d245c6: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
• 7a7ce02: 8007632: DES/3DES keys support in PKCS12 keystore
• a023b93: 8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny
• 84e985d: 8253920: Share method trampolines in CDS dynamic archive
• 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
• 504cb00: 8252113: Move jfr man page into jfr module
• 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
• 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
• ... and 92 more: https://git.openjdk.java.net/jdk/compare/2e510e04bd66c6d4bad0dcd51ebccf719defefa2...master

Your commit was automatically rebased without conflicts.

Pushed as commit a804c6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.