New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254871: Remove unnecessary string copy in NetworkInterface.c #821
Conversation
A small improvement to avoid extra string copy. [Tests] Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1. No new failure found. Change-Id: Icf657f04f967e78f1c97a165a74ca5f77985d4cf
|
@erik1iu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@kimbarrett Could you help to take look at this trivial patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@erik1iu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 97 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Michael-Mc-Mahon) but any other Committer may sponsor as well.
|
In the original the copy would appear to be a way of enforcing that the supplied name is not greater than the max IF name size (IFNAMSIZ), |
/integrate |
@erik1iu |
/sponsor |
@nick-arm @erik1iu Since your change was applied there have been 102 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a804c6a. |
A small improvement to avoid extra string copy.
[Tests]
Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
No new failure found.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/821/head:pull/821
$ git checkout pull/821