Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254871: Remove unnecessary string copy in NetworkInterface.c #821

Closed
wants to merge 1 commit into from

Conversation

e1iu
Copy link
Contributor

@e1iu e1iu commented Oct 23, 2020

A small improvement to avoid extra string copy.

[Tests]
Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
No new failure found.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254871: Remove unnecessary string copy in NetworkInterface.c

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/821/head:pull/821
$ git checkout pull/821

A small improvement to avoid extra string copy.

[Tests]
Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
No new failure found.

Change-Id: Icf657f04f967e78f1c97a165a74ca5f77985d4cf
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2020

👋 Welcome back erik1iu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@erik1iu The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 23, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2020

Webrevs

@e1iu
Copy link
Contributor Author

e1iu commented Oct 27, 2020

@kimbarrett Could you help to take look at this trivial patch?

Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@erik1iu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254871: Remove unnecessary string copy in NetworkInterface.c

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

  • 84e985d: 8253920: Share method trampolines in CDS dynamic archive
  • 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
  • 504cb00: 8252113: Move jfr man page into jfr module
  • 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
  • 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • 7679650: 8231231: The printing result is different from the case instruction
  • f7c59c6: 8255231: Avoid upcalls when initializing the statSampler
  • dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
  • ... and 87 more: https://git.openjdk.java.net/jdk/compare/2e510e04bd66c6d4bad0dcd51ebccf719defefa2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2020
@msheppar
Copy link

msheppar commented Oct 27, 2020

In the original the copy would appear to be a way of enforcing that the supplied name is not greater than the max IF name size (IFNAMSIZ),
so in the updated version if limit >= IFNAMSIZ is there any point in performing the search? As it is unlikely to match a returned interface name ?

@e1iu
Copy link
Contributor Author

e1iu commented Oct 27, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 27, 2020
@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@erik1iu
Your change (at version 6bcb109) is now ready to be sponsored by a Committer.

@nick-arm
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Oct 28, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2020
@openjdk
Copy link

openjdk bot commented Oct 28, 2020

@nick-arm @erik1iu Since your change was applied there have been 102 commits pushed to the master branch:

  • acd0e25: 8255254: Split os::reserve_memory and os::map_memory_to_file interfaces
  • dc85a3f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX
  • 1d245c6: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 7a7ce02: 8007632: DES/3DES keys support in PKCS12 keystore
  • a023b93: 8255394: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with ---illegal-access=deny
  • 84e985d: 8253920: Share method trampolines in CDS dynamic archive
  • 7d41a54: 8255450: runtime/ThreadCountLimit.java causes high system load
  • 504cb00: 8252113: Move jfr man page into jfr module
  • 552192f: 8255305: Add Linux x86_32 tier1 to submit workflow
  • 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
  • ... and 92 more: https://git.openjdk.java.net/jdk/compare/2e510e04bd66c6d4bad0dcd51ebccf719defefa2...master

Your commit was automatically rebased without conflicts.

Pushed as commit a804c6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@e1iu e1iu deleted the unnecessary-strcpy branch October 28, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
4 participants