Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider #8210

Closed
wants to merge 0 commits into from

Conversation

macarte
Copy link
Contributor

@macarte macarte commented Apr 12, 2022

On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges.

"Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc

No new tests added, keystore functionality and API remains unchanged, the local machine keystore types would require the tests to run in admin mode

Tested on windows, passes tier1 and tier2 tests


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8210/head:pull/8210
$ git checkout pull/8210

Update a local copy of the PR:
$ git checkout pull/8210
$ git pull https://git.openjdk.java.net/jdk pull/8210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8210

View PR using the GUI difftool:
$ git pr show -t 8210

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8210.diff

@macarte macarte marked this pull request as ready for review April 12, 2022 16:55
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@macarte The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 12, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2022

Webrevs

@macarte macarte changed the title 6782021: add support for localmachine keystores on windows JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider Apr 12, 2022
@macarte macarte closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security security-dev@openjdk.org
1 participant