JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider #8210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges.
"Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc
No new tests added, keystore functionality and API remains unchanged, the local machine keystore types would require the tests to run in admin mode
Tested on windows, passes tier1 and tier2 tests
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8210/head:pull/8210
$ git checkout pull/8210
Update a local copy of the PR:
$ git checkout pull/8210
$ git pull https://git.openjdk.java.net/jdk pull/8210/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8210
View PR using the GUI difftool:
$ git pr show -t 8210
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8210.diff